CI fixed#47
Conversation
|
@jordanmontt ignore these failing CI once you merge my PR opened in Containers-Array2D, it will automatically get resolved
|
| columns: firstString size + 1. | ||
| | distanceMatrix | | ||
| distanceMatrix := CTArray2D | ||
| extent: (firstString size + 1) @ (secondString size + 1). |
There was a problem hiding this comment.
I would say to instantiate the array 2d with the method #rows:columns: instead, for clarity
| self fillFirstTwoRowsAndColumnsWith: firstString and: secondString | ||
| ] | ||
| distanceMatrix := CTArray2D | ||
| extent: (secondString size + 2) @ (firstString size + 2). |
There was a problem hiding this comment.
same here
I would say to instantiate the array 2d with the method #rows:columns: instead, for clarity
| with: [ spec repository: 'github://pharo-containers/Containers-Array2D/src' ]. | ||
| "Packages" | ||
| spec | ||
| package: 'AI-EditDistances' with: [ spec requires: #( 'AIExternalVectorMatrix' ) ]; |
There was a problem hiding this comment.
you need to add the dependency to ContainersArray2D here, just as external vector matrix
|
Nice, let's wait tp have a green ci to integrate this. We need to resolve the previous pr first |
|
@jordanmontt all issues have been resolved |
|
@pankaj-bind I think there is a problem with the repository url format for the ContainersArray2D in baseline The correct url should be |
|
@pankaj-bind Now I think we need to resolve the previous PRs Implementation to make CI green |
|
@Alokzh it already resolved, I have added some new methods in Array2D and created a PR for that once that get merged, here CI will become green. |
|
Ah alright, I didn't see that |
3 participants
issue #45 resolved
to see the CI passing all test first merge this pharo-containers/Containers-Array2D#32
as current Containers-Array2D lacks some methods.