Add Missing Tests for AICosineSimilarityDistanceTest#53
Merged
jordanmontt merged 2 commits intopharo-ai:masterfrom May 12, 2025
Merged
Add Missing Tests for AICosineSimilarityDistanceTest#53jordanmontt merged 2 commits intopharo-ai:masterfrom
jordanmontt merged 2 commits intopharo-ai:masterfrom
Conversation
Contributor
Author
|
Hey @jordanmontt, please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test for
From AICosineSimilarityDistance.class.st I have removed previous method and added new.
Why?
The previous method lacks zero-vector handling (causing division-by-zero errors), uses non-standard array operations (*), and doesn’t validate inputs. The new method is more robust, portable, and includes input validation (length and numeric checks) and zero-vector handling, making it the better choice for reliable cosine similarity computation.