Add Missing Tests for AISzymkiewiczSimpsonCoefficientTest#56
Merged
jordanmontt merged 1 commit intopharo-ai:masterfrom Sep 23, 2025
Merged
Conversation
Contributor
Author
|
Hey @jordanmontt, please review this PR |
Member
|
Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for:
These tests were added to
AISzymkiewiczSimpsonCoefficientTestinsrc/AI-EditDistances-Tests/AISzymkiewiczSimpsonCoefficientTest.class.st.Why?
The previous test suite lacked coverage for critical edge cases (empty sets, identical sets, and disjoint sets), which are essential for ensuring the robustness of the
AISzymkiewiczSimpsonDistancemetric. The new tests verify that the Szymkiewicz-Simpson coefficient correctly handles these scenarios, improving reliability and aligning with the metric’s expected behavior (|X ∩ Y| / min(|X|, |Y|)).