Skip to content

deps: bump sass and codegen to fix vulnerable immutable version#810

Merged
rohan-chaturvedi merged 1 commit intomainfrom
deps--immutable
Mar 16, 2026
Merged

deps: bump sass and codegen to fix vulnerable immutable version#810
rohan-chaturvedi merged 1 commit intomainfrom
deps--immutable

Conversation

@rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Mar 16, 2026

Summary

  • Upgrade sass from 1.77.0 to 1.98.0
  • Upgrade @graphql-codegen/cli from 5.0.0 to 6.2.1
  • Upgrade @graphql-codegen/client-preset from 4.1.0 to 5.2.4
  • Upgrade @graphql-codegen/typescript-react-apollo from 4.1.0 to 4.4.1
  • Add graphql-sock ^1.0.0 (new peer dependency of client-preset v5)

This resolves Dependabot alert #282Prototype Pollution in immutable.

Context

Two transitive dependency chains pulled in vulnerable versions of immutable:

Path Vulnerable version
sassimmutable 4.3.0
@graphql-codegen/client-presetvisitor-plugin-commonrelay-operation-optimizer@ardatan/relay-compilerimmutable 3.7.6

Simply bumping immutable via resolutions wasn't viable because @ardatan/relay-compiler@12 pinned immutable@~3.7.6. Upgrading the parent packages was necessary to move both chains to @ardatan/relay-compiler@13 and sass@1.98, which both depend on immutable@^5.1.5.

After upgrade

└─┬ @graphql-codegen/client-preset@5.2.4
│ └── immutable@5.1.5 (deduped)
└─┬ sass@1.98.0
└── immutable@5.1.5

Verification

  • yarn codegen — GraphQL types regenerate successfully
  • npx tsc --noEmit — zero TypeScript errors
  • npx jest --no-coverage — 223/223 tests pass
  • Staging Docker Compose build and runtime — all services start, UI renders correctly
  • No .scss files in project source — sass upgrade has no direct styling impact
  • npm ls immutable confirms only 5.1.5 remains

Test plan

  • Verify all pages render without visual regressions (sass engine upgrade)
  • Create, read, edit, and delete secrets (E2EE encryption/decryption path)
  • Cross-environment secrets view renders correctly
  • Toast notifications display properly (react-toastify uses scss internally)
  • Signup and login flows complete without errors
  • Sync integrations trigger and report status correctly
  • Verify no runtime GraphQL type errors in browser console

Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
@rohan-chaturvedi rohan-chaturvedi merged commit 237bb7e into main Mar 16, 2026
7 checks passed
@rohan-chaturvedi rohan-chaturvedi deleted the deps--immutable branch March 16, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants