Open
Conversation
Works for bengali, update required for tests
Author
|
Updated. The module now works for both English and Bengali |
foobarmus
requested changes
Apr 20, 2019
Member
foobarmus
left a comment
foobarmus
left a comment
There was a problem hiding this comment.
I like the added functionality, but your code needs to be cleaner. You should:
- remove all the .pyc files
- not duplicate code in the if statement you added to the spell function
- always look for the cleanest, most maintainable way of coding something
- explain what you're doing to the word lists. I don't have time to read all those changes
If you make a serious effort to clean it up, and provide a bit of explanation, I'll review it again. Then if it's clean enough, I'll merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Bengali:
Works for bengali, update required for tests, this works just for bengali .