Skip to content

Commit 897453e

Browse files
committed
fix: hide nav buttons and keep image gallery height consistent when showing the loading indicator
1 parent 0cf38e7 commit 897453e

File tree

1 file changed

+21
-3
lines changed

1 file changed

+21
-3
lines changed

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2440,7 +2440,7 @@ function RemoteFunctions(config = {}) {
24402440
display: flex;
24412441
align-items: center;
24422442
justify-content: center;
2443-
height: 100%;
2443+
min-height: 112px;
24442444
color: #eaeaf0;
24452445
font-size: 14px;
24462446
}
@@ -2449,7 +2449,7 @@ function RemoteFunctions(config = {}) {
24492449
display: flex;
24502450
align-items: center;
24512451
justify-content: center;
2452-
height: 100%;
2452+
min-height: 112px;
24532453
color: #ff6b6b;
24542454
font-size: 14px;
24552455
}
@@ -2459,7 +2459,7 @@ function RemoteFunctions(config = {}) {
24592459
align-items: center;
24602460
justify-content: center;
24612461
min-width: 120px;
2462-
height: 116px;
2462+
min-height: 110px;
24632463
margin-left: 2px;
24642464
background: rgba(255,255,255,0.03);
24652465
border-radius: 8px;
@@ -2823,6 +2823,18 @@ function RemoteFunctions(config = {}) {
28232823
this._updateNavButtons();
28242824
},
28252825

2826+
_setNavButtonsVisibility: function(visible) {
2827+
const navLeft = this._shadow.querySelector('.phoenix-image-gallery-nav.left');
2828+
const navRight = this._shadow.querySelector('.phoenix-image-gallery-nav.right');
2829+
2830+
if (navLeft) {
2831+
navLeft.style.display = visible ? 'block' : 'none';
2832+
}
2833+
if (navRight) {
2834+
navRight.style.display = visible ? 'block' : 'none';
2835+
}
2836+
},
2837+
28262838
_updateNavButtons: function() {
28272839
// this function is responsible to update the nav buttons
28282840
// when we're at the very left, we hide the nav-left button completely
@@ -2859,6 +2871,8 @@ function RemoteFunctions(config = {}) {
28592871

28602872
rowElement.innerHTML = config.strings.imageGalleryLoadingInitial;
28612873
rowElement.className = 'phoenix-image-gallery-row phoenix-image-gallery-loading';
2874+
2875+
this._setNavButtonsVisibility(false);
28622876
},
28632877

28642878
_showLoadingMore: function() {
@@ -3105,6 +3119,8 @@ function RemoteFunctions(config = {}) {
31053119
container.scrollLeft = savedScrollPosition;
31063120
}, 0);
31073121
}
3122+
3123+
this._setNavButtonsVisibility(true);
31083124
},
31093125

31103126
_showError: function(message) {
@@ -3113,6 +3129,8 @@ function RemoteFunctions(config = {}) {
31133129

31143130
rowElement.innerHTML = message;
31153131
rowElement.className = 'phoenix-image-gallery-row phoenix-ribbon-error';
3132+
3133+
this._setNavButtonsVisibility(false);
31163134
},
31173135

31183136
// file name with which we need to save the image

0 commit comments

Comments
 (0)