Emmet Integration #2105
Closed
Emmet Integration #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
abose
reviewed
Jan 31, 2025
| if (newEditor) { | ||
| // Add listener to new editor | ||
| newEditor.off("change", handleKeyEvent); | ||
| newEditor.on("keydown", handleKeyEvent); |
Member
There was a problem hiding this comment.
off, then on is usually used to prevent event handler leaks. so always do editor.off(someEvent, handler) and then editor.on(someEvent, handler)
| } | ||
| if (newEditor) { | ||
| // Add listener to new editor | ||
| newEditor.off("change", handleKeyEvent); |
Member
There was a problem hiding this comment.
why both change and keydown handler?
| } | ||
|
|
||
| if (fileType === "css" || fileType === "scss" || fileType === "less") { | ||
| return { syntax: "css", type: "stylesheet" }; |
Member
There was a problem hiding this comment.
do verify that they share the same syntax code and not a specific less syntax is present.
| const fileType = editor.document.getLanguage().getId(); | ||
|
|
||
| if (fileType === "html") { | ||
| return { syntax: "html", type: "markup" }; |
Member
There was a problem hiding this comment.
Verify that emmenct can be used for php/jsp and other html like languages. Consider those languages too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds built-in Emmet support to Phoenix.
Expands Emmet abbreviation on Tab key press.
Places the cursor at the correct position after expansion, in a manner that users can directly start typing.
Preserves indentation to match the surrounding code.
Untitled.video.-.Made.with.Clipchamp.4.mp4