Fix forward word/vimword behaviors in caret mode#4312
Open
twio142 wants to merge 1 commit intophilc:masterfrom
Open
Fix forward word/vimword behaviors in caret mode#4312twio142 wants to merge 1 commit intophilc:masterfrom
twio142 wants to merge 1 commit intophilc:masterfrom
Conversation
Owner
|
Hey @twio142, I tried this PR and it does fix the issue where "w" does not move forward a word in caret mode. I haven't looked at the code in mode_visual.js -- it's in need of cleanup. From what I can tell from your diff, it looks like "move forward" was simply never implemented? Why does move backward work without the need to branch on alterMethod=="move"? |
Contributor
Author
That's because for forward moving was this character-by-character strategy implemented. While for backward moving it's just using this universal method: |
|
Just wondering if this could be merged at some point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.