fix: smooth scrolling for repetitive keydown#4328
Open
webkadiz wants to merge 1 commit intophilc:masterfrom
Open
fix: smooth scrolling for repetitive keydown#4328webkadiz wants to merge 1 commit intophilc:masterfrom
webkadiz wants to merge 1 commit intophilc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of this PR #3840 that I broke
What's going on: as it was discovered, no scrolling works in the visual mode with the smooth option.
This happens due to the fact that we do not re-enter the handler, believing that
animatewill do everything at once, but this does not happen. therefore, a forced repetition parameter is added. not the best solution, most likely the root of the problem is in another