change the default actionName to something that won't be ignored.#4462
Open
tylercal wants to merge 1 commit intophilc:masterfrom
Open
change the default actionName to something that won't be ignored.#4462tylercal wants to merge 1 commit intophilc:masterfrom
actionName to something that won't be ignored.#4462tylercal wants to merge 1 commit intophilc:masterfrom
Conversation
In philc@afeb65f, a change was made to exclude elements with a jsaction with an actionName of "_". However, as written, this also excludes any jsaction that doesn't specify an action name. I'm not sure if this is a desired behavior. As an example, on https://calendar.google.com/calendar/, each date in the mini calendar has a `jsaction="click:nngp;"` and each is clickable, but because no actionName is specified, Vimium does not place hints there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In afeb65f, a change was made to exclude elements with a jsaction with an actionName of "_". However, as written, this also excludes any jsaction that doesn't specify an action name. I'm not sure if this is a desired behavior.
As an example, on https://calendar.google.com/calendar/, each date in the mini calendar has a
jsaction="click:nngp;"and each is clickable, but because no actionName is specified, Vimium does not place hints there.