feat: passing link mode.name to lint marker's classname, added .bg-ta…#4784
Open
JUSTIVE wants to merge 1 commit intophilc:masterfrom
Open
feat: passing link mode.name to lint marker's classname, added .bg-ta…#4784JUSTIVE wants to merge 1 commit intophilc:masterfrom
JUSTIVE wants to merge 1 commit intophilc:masterfrom
Conversation
Contributor
|
Honestly, I like the flexibility of at least having a way for the user to add a custom style for new tab links. Whether the default style should be different may be a point of contention, but unless there is already another way to add a different style to new tab links, I think it would be beneficial to add one. |
Author
|
If you feel the default styles for new tabs don't match the PR, I'll remove them. The core goal of this PR is to provide the ability to specify different tab styles for different link types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4783 #2049
open a link in a new tablink hint is now visually distinguishable fromopen in current tab.It can be achieved by exposing the mode's name directly to link_hint's classname.
Since all the mode names are kebab-cased, it's fully compatible with CSS classnames.
Also, other modes can be modified by adding additional styles in CSS.
I adjusted the hue slightly from the original color to choose a new one.
Please feel free to share any thoughts or preferences regarding the color.