For my project I need the dropped item#40
Open
nerdware-timmmi wants to merge 3 commits intophilip-brink:masterfrom
Open
For my project I need the dropped item#40nerdware-timmmi wants to merge 3 commits intophilip-brink:masterfrom
nerdware-timmmi wants to merge 3 commits intophilip-brink:masterfrom
Conversation
Owner
|
Hi @jimtim, thanks for the PR and sincere apologies for the very late response, I haven't been on this project in some time. Could you explain a little more about why this change is helpful? Maybe I'm missing something, but why can't you get the dropped item using the indices returned? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Philip,
For my project I needed the dropped item and made the necessary changes for it. But this unfortunately brings the breaking change that you now need 5 parameters in onItemReorder. Maybe you could think of a better downward compatible solution?
Maybe the PR is also totally uninteresting for you, but then I would like to keep my solution in my fork for my project. You would then be mentioned in the licenses, and the BSD clause will not be removed. :-)
Thx