Use feedbackWidget when also using the itemDragHandle property#87
Open
coogle wants to merge 1 commit intophilip-brink:masterfrom
Open
Use feedbackWidget when also using the itemDragHandle property#87coogle wants to merge 1 commit intophilip-brink:masterfrom
feedbackWidget when also using the itemDragHandle property#87coogle wants to merge 1 commit intophilip-brink:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in
DragAndDropItemWrapperwhen using theitemDragHandleproperty. When set, this property builds a feedback widget differently than the other possibilities -- except it doesn't honor thefeedbackWidgetparameter of theDragAndDropItemclass (it does in all other cases).This patch fixes that issue by defaulting to using a provided
feedbackWidgetWidget, and only falls back to thechild(e.g. "normal" widget iffeedbackWidgetisn't provided.