feat: improve error handling in Application and FeatureFactory with specific exceptions

Author: daantimmer

cucumber_cpp/library/Application.cpp

@@ -143,14 +143,7 @@ namespace cucumber_cpp::library
 
         runCommand = cli.add_subcommand("run")->parse_complete_callback([this]
             {
-                try
-                {
-                    RunFeatures();
-                }
-                catch (std::exception& error)
-                {
-                    std::cerr << error.what();
-                }
+                RunFeatures();
             });
 
         runCommand->add_option("-t,--tag", options.tags, "Cucumber tag expression");
@@ -187,6 +180,12 @@ namespace cucumber_cpp::library
             std::cout << error.what() << std::endl;
             return GetExitCode(engine::Result::failed);
         }
+        catch (const UnsupportedAsteriskError& error)
+        {
+            std::cout << "UnsupportedAsteriskError error:\n\n";
+            std::cout << error.what() << std::endl;
+            return GetExitCode(engine::Result::failed);
+        }
         catch (const cucumber_expression::Error& error)
         {
             std::cout << "Cucumber Expression error:\n\n";
@@ -199,6 +198,11 @@ namespace cucumber_cpp::library
             std::cout << error.what() << std::endl;
             return GetExitCode(engine::Result::failed);
         }
+        catch (...)
+        {
+            std::cout << "Unknown error";
+            return GetExitCode(engine::Result::failed);
+        }
 
         return GetExitCode();
     }

cucumber_cpp/library/InternalError.hpp

@@ -16,6 +16,13 @@ namespace cucumber_cpp::library
 
         const std::source_location sourceLocation;
     };
+
+    struct UnsupportedAsteriskError : std::runtime_error
+    {
+        UnsupportedAsteriskError(const std::string& str)
+            : std::runtime_error{ str }
+        {}
+    };
 }
 
 #endif

cucumber_cpp/library/engine/FeatureFactory.cpp

@@ -13,6 +13,7 @@
 #include "cucumber/messages/scenario.hpp"
 #include "cucumber/messages/step.hpp"
 #include "cucumber/messages/tag.hpp"
+#include "cucumber_cpp/library/InternalError.hpp"
 #include "cucumber_cpp/library/StepRegistry.hpp"
 #include "cucumber_cpp/library/TagExpression.hpp"
 #include "cucumber_cpp/library/engine/FeatureInfo.hpp"
@@ -24,12 +25,14 @@
 #include <algorithm>
 #include <cstddef>
 #include <filesystem>
+#include <format>
 #include <functional>
 #include <map>
 #include <memory>
 #include <optional>
 #include <ranges>
 #include <set>
+#include <stdexcept>
 #include <string>
 #include <string_view>
 #include <utility>
@@ -149,7 +152,15 @@ namespace cucumber_cpp::library::engine
         {
             auto table = TableFactory(pickleStep.argument);
 
-            scenarioInfo.Children().push_back(featureTreeFactory.CreateStepInfo(stepTypeLut.at(*pickleStep.type), pickleStep.text, scenarioInfo, step.location.line, step.location.column.value_or(0), std::move(table)));
+            try
+            {
+                scenarioInfo.Children().push_back(featureTreeFactory.CreateStepInfo(stepTypeLut.at(*pickleStep.type), pickleStep.text, scenarioInfo, step.location.line, step.location.column.value_or(0), std::move(table)));
+            }
+            catch (const std::out_of_range& e)
+            {
+
+                throw UnsupportedAsteriskError{ std::format("{}:{}: * steps are not supported", scenarioInfo.FeatureInfo().Path().c_str(), step.location.line) };
+            }
         }
 
         void ConstructSteps(const FeatureTreeFactory& featureTreeFactory, ScenarioInfo& scenarioInfo, const FlatAst& flatAst, const std::vector<cucumber::messages::pickle_step>& pickleSteps)