feat!: rewrite to use cucumber messages #273
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,4 @@ ignore: | |
| - external | ||
| - megalinter-reports | ||
| - testdata | ||
| - compatibility | ||
daantimmer marked this conversation as resolved.
Show resolved
Hide resolved
daantimmer marked this conversation as resolved.
Show resolved
Hide resolved
daantimmer marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daantimmer marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. [MegaLinter] reported by reviewdog 🐶 amp-cucumber-cpp-runner/CMakePresets.json Lines 2 to 139 in 9986ec8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| function(add_compatibility_kit name) | ||
| set(libname compatibility.${name}.test) | ||
| add_executable(${libname}) | ||
|
|
||
| if(CCR_BUILD_TESTS) | ||
| add_test(NAME ${libname} COMMAND ${libname}) | ||
| endif() | ||
|
|
||
| target_link_libraries(${libname} PRIVATE | ||
| cucumber_cpp | ||
| gtest_main | ||
| ) | ||
|
|
||
| target_include_directories(${libname} PUBLIC | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}> | ||
| ) | ||
|
|
||
| target_sources(${libname} PRIVATE | ||
| compatibility.cpp | ||
| ) | ||
|
|
||
|
|
||
| if (EXISTS ${CMAKE_CURRENT_LIST_DIR}/${name}/${name}.cpp) | ||
| target_sources(${libname} PRIVATE | ||
| ${name}/${name}.cpp | ||
| ) | ||
| else() | ||
| set(SKIP_TEST On) | ||
| endif() | ||
|
|
||
| string(REPLACE "-" "_" KITNAME ${name}) | ||
|
|
||
| target_compile_definitions(${libname} PRIVATE | ||
| KIT_NAME=${KITNAME} | ||
| KIT_STRING="${name}" | ||
| KIT_FOLDER="${CMAKE_CURRENT_SOURCE_DIR}/${name}" | ||
| KIT_NDJSON_FILE="${CMAKE_CURRENT_SOURCE_DIR}/${name}/${name}.ndjson" | ||
| $<$<BOOL:${SKIP_TEST}>:SKIP_TEST> | ||
| ) | ||
| endfunction() | ||
|
|
||
| file(GLOB kits RELATIVE ${CMAKE_CURRENT_LIST_DIR} ${CMAKE_CURRENT_LIST_DIR}/*) | ||
| foreach(kit ${kits}) | ||
| if (IS_DIRECTORY ${CMAKE_CURRENT_LIST_DIR}/${kit}) | ||
| message(STATUS "Adding compatibility kit: ${kit}") | ||
| add_compatibility_kit(${kit}) | ||
| endif() | ||
| endforeach() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #include "cucumber_cpp/CucumberCpp.hpp" | ||
| #include <string> | ||
|
|
||
| STEP(R"(^a (.*?) with (.*?)$)", (const std::string& arg1, const std::string& arg2)) | ||
| { | ||
| // no-op | ||
| } | ||
|
|
||
| STEP(R"(^a step with (.*?)$)", (const std::string& arg1)) | ||
| { | ||
| // no-op | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Feature: Ambiguous steps | ||
| Multiple step definitions that match a pickle step result in an AMBIGUOUS status, since Cucumnber cannot determine | ||
| which one to execute. | ||
|
|
||
| Scenario: Multiple step definitions for a step | ||
| Given a step with multiple definitions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| {"meta":{"protocolVersion":"31.0.0","implementation":{"name":"fake-cucumber","version":"123.45.6"},"cpu":{"name":"arm64"},"os":{"name":"darwin","version":"24.5.0"},"runtime":{"name":"Node.js","version":"24.4.1"},"ci":{"name":"GitHub Actions","url":"https://github.com/cucumber-ltd/shouty.rb/actions/runs/154666429","buildNumber":"154666429","git":{"revision":"99684bcacf01d95875834d87903dcb072306c9ad","remote":"https://github.com/cucumber-ltd/shouty.rb.git","branch":"main"}}}} | ||
| {"source":{"data":"Feature: Ambiguous steps\n Multiple step definitions that match a pickle step result in an AMBIGUOUS status, since Cucumnber cannot determine\n which one to execute.\n\n Scenario: Multiple step definitions for a step\n Given a step with multiple definitions\n","uri":"samples/ambiguous/ambiguous.feature","mediaType":"text/x.cucumber.gherkin+plain"}} | ||
| {"gherkinDocument":{"feature":{"tags":[],"location":{"line":1,"column":1},"language":"en","keyword":"Feature","name":"Ambiguous steps","description":" Multiple step definitions that match a pickle step result in an AMBIGUOUS status, since Cucumnber cannot determine\n which one to execute.","children":[{"scenario":{"id":"1","tags":[],"location":{"line":5,"column":3},"keyword":"Scenario","name":"Multiple step definitions for a step","description":"","steps":[{"id":"0","location":{"line":6,"column":5},"keyword":"Given ","keywordType":"Context","text":"a step with multiple definitions"}],"examples":[]}}]},"comments":[],"uri":"samples/ambiguous/ambiguous.feature"}} | ||
| {"pickle":{"id":"3","uri":"samples/ambiguous/ambiguous.feature","location":{"line":5,"column":3},"astNodeIds":["1"],"tags":[],"name":"Multiple step definitions for a step","language":"en","steps":[{"id":"2","text":"a step with multiple definitions","type":"Context","astNodeIds":["0"]}]}} | ||
| {"stepDefinition":{"id":"4","pattern":{"type":"REGULAR_EXPRESSION","source":"^a (.*?) with (.*?)$"},"sourceReference":{"uri":"samples/ambiguous/ambiguous.ts","location":{"line":3}}}} | ||
| {"stepDefinition":{"id":"5","pattern":{"type":"REGULAR_EXPRESSION","source":"^a step with (.*?)$"},"sourceReference":{"uri":"samples/ambiguous/ambiguous.ts","location":{"line":7}}}} | ||
| {"testRunStarted":{"id":"6","timestamp":{"seconds":0,"nanos":0}}} | ||
| {"testCase":{"id":"7","pickleId":"3","testSteps":[{"id":"8","pickleStepId":"2","stepDefinitionIds":["4","5"],"stepMatchArgumentsLists":[{"stepMatchArguments":[{"group":{"start":2,"value":"step","children":[]}},{"group":{"start":12,"value":"multiple definitions","children":[]}}]},{"stepMatchArguments":[{"group":{"start":12,"value":"multiple definitions","children":[]}}]}]}],"testRunStartedId":"6"}} | ||
| {"testCaseStarted":{"id":"9","testCaseId":"7","timestamp":{"seconds":0,"nanos":1000000},"attempt":0}} | ||
| {"testStepStarted":{"testCaseStartedId":"9","testStepId":"8","timestamp":{"seconds":0,"nanos":2000000}}} | ||
| {"testStepFinished":{"testCaseStartedId":"9","testStepId":"8","testStepResult":{"status":"AMBIGUOUS","duration":{"seconds":0,"nanos":0}},"timestamp":{"seconds":0,"nanos":3000000}}} | ||
| {"testCaseFinished":{"testCaseStartedId":"9","timestamp":{"seconds":0,"nanos":4000000},"willBeRetried":false}} | ||
| {"testRunFinished":{"testRunStartedId":"6","timestamp":{"seconds":0,"nanos":5000000},"success":false}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { Given } from '@cucumber/fake-cucumber' | ||
|
|
||
| Given(/^a (.*?) with (.*?)$/, function () { | ||
| // first one | ||
| }) | ||
|
|
||
| Given(/^a step with (.*)$/, function () { | ||
| // second one | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| #include "cucumber_cpp/CucumberCpp.hpp" | ||
| #include "cucumber_cpp/library/engine/ExecutionContext.hpp" | ||
| #include <cstdint> | ||
| #include <filesystem> | ||
| #include <fstream> | ||
| #include <ios> | ||
| #include <numeric> | ||
| #include <source_location> | ||
| #include <sstream> | ||
| #include <string> | ||
|
|
||
| namespace | ||
| { | ||
| const std::filesystem::path currentCompileDir = std::filesystem::path{ std::source_location::current().file_name() }.parent_path(); | ||
| } | ||
|
|
||
| WHEN(R"(the string {string} is attached as {string})", (const std::string& text, const std::string& mediaType)) | ||
| { | ||
| Attach(text, mediaType); | ||
| } | ||
|
|
||
| WHEN(R"(the string {string} is logged)", (const std::string& text)) | ||
| { | ||
| Log(text); | ||
| } | ||
|
|
||
| WHEN(R"(text with ANSI escapes is logged)") | ||
| { | ||
| Log("This displays a \x1b[31mr\x1b[0m\x1b[91ma\x1b[0m\x1b[33mi\x1b[0m\x1b[32mn\x1b[0m\x1b[34mb\x1b[0m\x1b[95mo\x1b[0m\x1b[35mw\x1b[0m"); | ||
| } | ||
|
|
||
| WHEN(R"(the following string is attached as {string}:)", (const std::string& mediaType)) | ||
| { | ||
| Attach(docString->content, mediaType); | ||
| } | ||
|
|
||
| WHEN(R"(an array with {int} bytes is attached as {string})", (std::int32_t size, const std::string& mediaType)) | ||
| { | ||
| std::string data(size, '\0'); | ||
| std::iota(data.begin(), data.end(), 0); | ||
| std::stringstream stream{ data }; | ||
| Attach(stream, mediaType); | ||
| } | ||
|
|
||
| WHEN(R"(a PDF document is attached and renamed)") | ||
| { | ||
| std::ifstream pdfFile{ currentCompileDir / "document.pdf", std::ios::binary }; | ||
| Attach(pdfFile, cucumber_cpp::library::engine::AttachOptions{ "application/pdf", "renamed.pdf" }); | ||
| } | ||
|
|
||
| WHEN(R"(a link to {string} is attached)", (const std::string& url)) | ||
| { | ||
| Link(url); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.