Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Nov 11, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This pull request introduces two new devcontainer templates for C++ and Rust, along with supporting configuration files and CI/CD automation for publishing and maintaining these templates. The changes are grouped into template additions, automation enhancements, and configuration improvements.

Devcontainer Template Additions:

  • Added a C++ devcontainer template:

    • Introduced .devcontainer/cpp-template/devcontainer-template.json describing the template, options, and metadata.
    • Added Dockerfile and devcontainer.json for building the C++ development environment. [1] [2]
    • Included a Dependabot configuration for automated Docker dependency updates.
  • Added a Rust devcontainer template:

    • Introduced .devcontainer/rust-template/devcontainer-template.json with Rust-specific metadata and options.
    • Added Dockerfile and devcontainer.json for building the Rust development environment. [1] [2]
    • Included a Dependabot configuration for automated Docker dependency updates.

Automation and CI/CD Enhancements:

  • Added a new GitHub Actions job to publish devcontainer templates as OCI artifacts, update documentation, and create pull requests for README changes.

Configuration and Maintenance Improvements:

  • Updated release-please-config.json to ensure version bumps in the new devcontainer template files are tracked and released automatically.
  • Updated .mega-linter.yml to exclude the new template Dockerfiles from Dockerfile linting.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner November 11, 2025 12:33
Copilot AI review requested due to automatic review settings November 11, 2025 12:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a devcontainer template for C++ to enable easier project setup and distribution. The template packages the existing C++ devcontainer as a reusable template that can be discovered and used by other projects.

Key Changes:

  • Adds a new cpp-template devcontainer template with configuration and documentation files
  • Configures automated publishing of devcontainer templates via GitHub Actions
  • Integrates template versioning with the existing release-please workflow

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
release-please-config.json Adds extra-files configuration to track template version
.github/workflows/continuous-integration.yml Adds new job to publish devcontainer templates as OCI artifacts
.devcontainer/cpp-template/devcontainer-template.json Defines template metadata and configuration
.devcontainer/cpp-template/.github/dependabot.yml Provides Dependabot configuration for template users
.devcontainer/cpp-template/.devcontainer/devcontainer.json Basic devcontainer configuration referencing Dockerfile
.devcontainer/cpp-template/.devcontainer/Dockerfile Simple Dockerfile that extends the base C++ container image

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 20 0 0 0.52s
✅ DOCKERFILE hadolint 2 0 0 0.78s
✅ GHERKIN gherkin-lint 6 0 0 2.33s
✅ JSON npm-package-json-lint yes no no 0.46s
✅ JSON prettier 19 4 0 0 0.57s
✅ JSON v8r 19 0 0 8.08s
✅ MARKDOWN markdownlint 11 0 0 0 0.9s
✅ MARKDOWN markdown-table-formatter 11 0 0 0 0.23s
✅ REPOSITORY gitleaks yes no no 1.15s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 30.21s
✅ REPOSITORY secretlint yes no no 1.0s
✅ REPOSITORY syft yes no no 2.11s
✅ REPOSITORY trivy yes no no 4.93s
✅ REPOSITORY trivy-sbom yes no no 0.25s
✅ REPOSITORY trufflehog yes no no 3.13s
⚠️ SPELL lychee 77 1 0 11.56s
✅ YAML prettier 28 0 0 0 1.4s
✅ YAML v8r 28 0 0 7.97s
✅ YAML yamllint 28 0 0 1.29s

Detailed Issues

⚠️ SPELL / lychee - 1 error
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
[500] https://api.securityscorecards.dev/projects/github.com/philips-software/amp-devcontainer/badge | Network error: Internal Server Error
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....123
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in README.md
[500] https://api.securityscorecards.dev/projects/github.com/philips-software/amp-devcontainer/badge | Network error: Internal Server Error

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1010

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 546.53 MB 546.53 MB +1.02 kB (+0%) 🔼
linux/arm64 501.16 MB 501.16 MB 951 B (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1010

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 682.59 MB 682.59 MB 153 B (0%) 🔽
linux/arm64 664.94 MB 664.94 MB 44 B (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Test Results

 5 files  ±0   5 suites  ±0   3m 53s ⏱️ - 2m 0s
31 tests ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 
65 runs  ±0  65 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cd0fbc7. ± Comparison against base commit 72e027d.

♻️ This comment has been updated with latest results.

Copilot AI review requested due to automatic review settings November 11, 2025 13:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

@rjaegers rjaegers changed the title feat: add devcontainer template for cpp feat: add devcontainer templates Nov 11, 2025
Copilot AI review requested due to automatic review settings November 11, 2025 17:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings November 18, 2025 06:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings November 18, 2025 07:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Copy link
Collaborator

@EkelmansPh EkelmansPh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

@sonarqubecloud
Copy link

@rjaegers rjaegers added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit 6b53395 Nov 18, 2025
34 checks passed
@rjaegers rjaegers deleted the feature/add-devcontainer-templates branch November 18, 2025 13:05
@github-actions
Copy link
Contributor

Pull Request Report (#1010)

Static measures

Description Value
Number of added lines 154
Number of deleted lines 28
Number of changed files 14
Number of commits 10
Number of reviews 13
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 11
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 2
Get the total number of participants of a Pull Request 8

Time related measures

Description Value
PR lead time (from creation to close of PR) 7 Days
Time that was spend on the branch before the PR was created 18.9 Min
Time that was spend on the branch before the PR was merged 7 Days
Time to merge after last review 2.1 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 40.4 Min
Total time spend in last status check run on PR 14.4 Min

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants