Skip to content

Conversation

@rjaegers
Copy link
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request makes a minor adjustment to the .devcontainer/cpp/Dockerfile by creating a .amp directory in the root user's home. This change is necessary for tooling that expects this directory to exist. If it doesn't exist clangd ignores the argument pointing to the directory where compile-commands.json would reside.

  • Environment setup:
    • Added a step to create the /root/.amp directory during container setup.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner November 25, 2025 12:02
Copilot AI review requested due to automatic review settings November 25, 2025 12:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a tooling issue where clangd ignores configuration arguments when the .amp directory doesn't exist. The change pre-creates the /root/.amp directory during container setup to ensure clangd can properly locate the compile-commands.json file.

Key Changes:

  • Pre-create /root/.amp directory in the cpp container's Dockerfile to ensure clangd functionality

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 20 0 0 0.51s
✅ DOCKERFILE hadolint 2 0 0 0.79s
✅ GHERKIN gherkin-lint 6 0 0 2.34s
✅ JSON npm-package-json-lint yes no no 0.52s
✅ JSON prettier 19 4 0 0 0.57s
✅ JSON v8r 19 0 0 7.65s
✅ MARKDOWN markdownlint 11 0 0 0 0.89s
✅ MARKDOWN markdown-table-formatter 11 0 0 0 0.24s
✅ REPOSITORY gitleaks yes no no 0.98s
✅ REPOSITORY git_diff yes no no 0.02s
✅ REPOSITORY grype yes no no 29.6s
✅ REPOSITORY secretlint yes no no 1.01s
✅ REPOSITORY syft yes no no 2.12s
✅ REPOSITORY trivy yes no no 5.46s
✅ REPOSITORY trivy-sbom yes no no 0.25s
✅ REPOSITORY trufflehog yes no no 2.64s
✅ SPELL lychee 77 0 0 21.44s
✅ YAML prettier 28 0 0 0 1.16s
✅ YAML v8r 28 0 0 8.37s
✅ YAML yamllint 28 0 0 1.04s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1025

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 681.92 MB 681.9 MB 13.03 kB (0%) 🔽
linux/arm64 664.26 MB 664.27 MB +1.46 kB (+0%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1025

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 545.86 MB 545.86 MB 626 B (0%) 🔽
linux/arm64 500.48 MB 500.48 MB +116 B (+0%) 🔼

@rjaegers rjaegers changed the title fix: pre-create .amp directory to allow clangd to find it fix(cpp): pre-create .amp directory to allow clangd to find it Nov 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Test Results

 5 files  ±0   5 suites  ±0   3m 41s ⏱️ ±0s
32 tests +1  32 ✅ +1  0 💤 ±0  0 ❌ ±0 
67 runs  +2  67 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 4dd0b6a. ± Comparison against base commit e5cabe2.

♻️ This comment has been updated with latest results.

Copilot AI review requested due to automatic review settings November 25, 2025 16:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@sonarqubecloud
Copy link

@rjaegers rjaegers added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 533d040 Nov 25, 2025
77 of 94 checks passed
@rjaegers rjaegers deleted the fix/clangd-ignores-argument-for-non-existing-dir branch November 25, 2025 19:02
@github-actions
Copy link
Contributor

Pull Request Report (#1025)

Static measures

Description Value
Number of added lines 6
Number of deleted lines 0
Number of changed files 2
Number of commits 3
Number of reviews 4
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 3
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 7 Hours
Time that was spend on the branch before the PR was created 1.9 Min
Time that was spend on the branch before the PR was merged 7 Hours
Time to merge after last review 2.7 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 49.3 Min
Total time spend in last status check run on PR 2.4 Hours

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.6.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants