Skip to content

Comments

chore: add a first run notice detailing the version of amp-devcontainer#688

Closed
Ron (rjaegers) wants to merge 7 commits intomainfrom
feature/add-first-run-notice
Closed

chore: add a first run notice detailing the version of amp-devcontainer#688
Ron (rjaegers) wants to merge 7 commits intomainfrom
feature/add-first-run-notice

Conversation

@rjaegers
Copy link
Member

🚀 Hey, I have created a Pull Request

Description of changes

This PR adds a first-run-notice file that will be displayed when the container is first started displaying the container version number.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers Ron (rjaegers) requested a review from a team as a code owner January 9, 2025 09:28
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

 2 files  ±0   2 suites  ±0   1m 22s ⏱️ +4s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f255cf6. ± Comparison against base commit 7e130ea.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 17 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.53s
✅ GHERKIN gherkin-lint 2 0 0.86s
✅ JSON npm-package-json-lint yes no 1.01s
✅ JSON prettier 15 1 0 0.38s
✅ JSON v8r 14 0 9.43s
✅ MARKDOWN markdownlint 8 0 0 0.85s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.23s
✅ REPOSITORY checkov yes no 15.02s
✅ REPOSITORY gitleaks yes no 0.9s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.48s
✅ REPOSITORY secretlint yes no 0.99s
✅ REPOSITORY syft yes no 1.22s
✅ REPOSITORY trivy yes no 6.3s
✅ REPOSITORY trivy-sbom yes no 0.08s
✅ REPOSITORY trufflehog yes no 4.13s
✅ SPELL lychee 60 0 2.36s
✅ YAML prettier 22 0 0 0.66s
✅ YAML v8r 22 0 7.25s
✅ YAML yamllint 22 0 0.38s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:3bbba8b71252f19a6ebbd02f4f8ad8e63c82a591a4c4a1742ba6eeff114a205e

OS/Platform Previous Size Current Size Delta
linux/amd64 484.88M 484.88M 762.00 (+0.00%)
linux/arm64 623.73M 623.73M 764.00 (+0.00%)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:132e2dc9dddc862fe7dede13df9d4e09d5cb3fbc9ff6f1ffabb07b102adddf07

OS/Platform Previous Size Current Size Delta
linux/amd64 697.85M 697.85M 722.00 (+0.00%)
linux/arm64 679.20M 679.20M 730.00 (+0.00%)

@rjaegers Ron (rjaegers) marked this pull request as draft January 9, 2025 10:11
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Pull Request Report (#688)

Static measures

Description Value
Number of added lines 37
Number of deleted lines 1
Number of changed files 7
Number of commits 7
Number of reviews 0
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 0
Get the total number of participants of a Pull Request 3

Time related measures

Description Value
PR lead time (from creation to close of PR) 61.2 Days
Time that was spend on the branch before the PR was created 2.4 Min
Time that was spend on the branch before the PR was merged 0 Sec
Time to merge after last review 0 Sec

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 21.6 Min
Total time spend in last status check run on PR 6.8 Min

@rjaegers Ron (rjaegers) deleted the feature/add-first-run-notice branch June 18, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant