Skip to content

Comments

chore: remove matepek.vscode-catch2-test-adapter#738

Merged
Ron (rjaegers) merged 5 commits intomainfrom
feature/remove-vscode-catch2-test-adapter
Mar 27, 2025
Merged

chore: remove matepek.vscode-catch2-test-adapter#738
Ron (rjaegers) merged 5 commits intomainfrom
feature/remove-vscode-catch2-test-adapter

Conversation

@rjaegers
Copy link
Member

@rjaegers Ron (rjaegers) commented Mar 7, 2025

🚀 Hey, I have created a Pull Request

Description of changes

The functionality provided by this extension is now provided by the cmake-tools extension. This extension is no longer needed. Having two extensions doing "the same thing" was a source of confusion. Please note that the functionality of test-discovery is different between the two extensions. While matepek.vscode-catch2-test-adapter was able to automatically discover tests cmake-tools needs to be told what to add to CTest. This can be done via e.g. add_test or via one of the discovery methods like gtest_add_tests or gtest_discover_tests.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

The functionality provided by this extension is now provided by the cmake-tools extension. This extension is no longer needed.
@rjaegers Ron (rjaegers) requested a review from a team as a code owner March 7, 2025 12:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:fc2b68db6b6bb18c1d88a7d06c5886d9a48e00a58aa64a694729a784ca5195c9

OS/Platform Previous Size Current Size Delta
linux/amd64 484.88M 484.88M 5.17K (+0.00%)
linux/arm64 623.73M 623.73M 5.19K (+0.00%)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:c34411bc65ee17e6c1e205389993dc6d80dedc598cf60521437c4afe4c04213f

OS/Platform Previous Size Current Size Delta
linux/amd64 697.85M 701.50M 3.66M (+0.52%)
linux/arm64 679.20M 683.20M 4.01M (+0.59%)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 17 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.49s
✅ GHERKIN gherkin-lint 2 0 0.86s
✅ JSON npm-package-json-lint yes no 0.34s
✅ JSON prettier 15 1 0 0.36s
✅ JSON v8r 15 0 7.16s
✅ MARKDOWN markdownlint 8 0 0 0.83s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.23s
✅ REPOSITORY checkov yes no 14.72s
✅ REPOSITORY gitleaks yes no 0.9s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.47s
✅ REPOSITORY secretlint yes no 1.01s
✅ REPOSITORY syft yes no 1.18s
✅ REPOSITORY trivy yes no 4.96s
✅ REPOSITORY trivy-sbom yes no 0.08s
✅ REPOSITORY trufflehog yes no 4.16s
✅ SPELL lychee 59 0 6.43s
✅ YAML prettier 22 0 0 0.62s
✅ YAML v8r 22 0 5.64s
✅ YAML yamllint 22 0 0.39s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Test Results

 2 files  ±0   2 suites  ±0   1m 22s ⏱️ -1s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 49920cd. ± Comparison against base commit 6dd40e7.

♻️ This comment has been updated with latest results.

@EkelmansPh EkelmansPh self-requested a review March 11, 2025 08:15
@sonarqubecloud
Copy link

@rjaegers Ron (rjaegers) added this pull request to the merge queue Mar 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2025
@rjaegers Ron (rjaegers) added this pull request to the merge queue Mar 27, 2025
Merged via the queue into main with commit 8491493 Mar 27, 2025
22 checks passed
@rjaegers Ron (rjaegers) deleted the feature/remove-vscode-catch2-test-adapter branch March 27, 2025 14:23
@github-actions
Copy link
Contributor

Pull Request Report (#738)

Static measures

Description Value
Number of added lines 2
Number of deleted lines 5
Number of changed files 3
Number of commits 5
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 20.1 Days
Time that was spend on the branch before the PR was created 1.7 Min
Time that was spend on the branch before the PR was merged 20.1 Days
Time to merge after last review 9.2 Days

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 21.3 Min
Total time spend in last status check run on PR 7.5 Min

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants