Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Jun 16, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This PR fixes the acceptance tests for non-PR branches and fix the annotations on the main image.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings June 16, 2025 06:54
@rjaegers rjaegers requested a review from a team as a code owner June 16, 2025 06:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes acceptance tests on the default branch by adjusting how the IMAGE_VERSION secret is set, and corrects a minor grammar issue in the README.

  • Corrected phrasing in the release notes description in README.md
  • Added a conditional in the workflow to set IMAGE_VERSION secret differently for PR builds versus the default branch

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
README.md Updated “that included” to “that include” for present-tense accuracy
.github/workflows/wc-acceptance-test.yml Wrapped gh secret set calls in an if/else to handle PR vs edge
Comments suppressed due to low confidence (2)

.github/workflows/wc-acceptance-test.yml:33

  • The indentation of this if block is inconsistent with the surrounding script lines and may break execution. Align it to the same level as set -Eeuo pipefail.
if [[ "${{ github.event_name }}" == "pull_request" ]]; then

.github/workflows/wc-acceptance-test.yml:34

  • [nitpick] For clarity, consider using the long-form flag --app codespaces instead of the short -a codespaces in the gh secret set command.
gh secret set -a codespaces IMAGE_VERSION --body "pr-${{ github.event.pull_request.number }}"

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edge to ghcr.io/philips-software/amp-devcontainer-rust:pr-824

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend
linux/amd64 481.27M 481.27M 0.00 (+0.00%) 🔄
linux/arm64 432.74M 432.74M 0.00 (+0.00%) 🔄

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edge to ghcr.io/philips-software/amp-devcontainer-cpp:pr-824

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend
linux/amd64 691.26M 691.26M 0.00 (+0.00%) 🔄
linux/arm64 673.40M 673.40M 0.00 (+0.00%) 🔄

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 18 0 0 0.45s
✅ DOCKERFILE hadolint 2 0 0 0.8s
✅ GHERKIN gherkin-lint 2 0 0 0.95s
✅ JSON npm-package-json-lint yes no no 0.38s
✅ JSON prettier 16 1 0 0 0.4s
✅ JSON v8r 16 0 0 9.59s
✅ MARKDOWN markdownlint 9 0 0 0 0.85s
✅ MARKDOWN markdown-table-formatter 9 0 0 0 0.25s
✅ REPOSITORY checkov yes no no 16.3s
✅ REPOSITORY gitleaks yes no no 0.4s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 22.9s
✅ REPOSITORY secretlint yes no no 0.97s
✅ REPOSITORY syft yes no no 1.9s
✅ REPOSITORY trivy yes no no 5.46s
✅ REPOSITORY trivy-sbom yes no no 0.22s
✅ REPOSITORY trufflehog yes no no 3.09s
✅ SPELL lychee 62 0 0 4.82s
✅ YAML prettier 23 0 0 0 0.87s
✅ YAML v8r 23 0 0 7.32s
✅ YAML yamllint 23 0 0 0.68s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

Test Results

 4 files  ±0   4 suites  ±0   2m 28s ⏱️ -1s
31 tests ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 
66 runs  ±0  66 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e46e655. ± Comparison against base commit 66aec0a.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

@rjaegers rjaegers merged commit e0d51f9 into main Jun 18, 2025
34 checks passed
@rjaegers rjaegers deleted the feature/fix-acceptance-tests-on-default-branch branch June 18, 2025 17:56
@github-actions
Copy link
Contributor

Pull Request Report (#824)

Static measures

Description Value
Number of added lines 58
Number of deleted lines 13
Number of changed files 7
Number of commits 28
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 2.5 Days
Time that was spend on the branch before the PR was created 14 Sec
Time that was spend on the branch before the PR was merged 2.5 Days
Time to merge after last review 1.2 Days

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 27.4 Min
Total time spend in last status check run on PR 22 Min

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants