-
Notifications
You must be signed in to change notification settings - Fork 7
chore: fix acceptance tests on default branch #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix acceptance tests on default branch #824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes acceptance tests on the default branch by adjusting how the IMAGE_VERSION secret is set, and corrects a minor grammar issue in the README.
- Corrected phrasing in the release notes description in README.md
- Added a conditional in the workflow to set
IMAGE_VERSIONsecret differently for PR builds versus the default branch
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated “that included” to “that include” for present-tense accuracy |
| .github/workflows/wc-acceptance-test.yml | Wrapped gh secret set calls in an if/else to handle PR vs edge |
Comments suppressed due to low confidence (2)
.github/workflows/wc-acceptance-test.yml:33
- The indentation of this
ifblock is inconsistent with the surrounding script lines and may break execution. Align it to the same level asset -Eeuo pipefail.
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
.github/workflows/wc-acceptance-test.yml:34
- [nitpick] For clarity, consider using the long-form flag
--app codespacesinstead of the short-a codespacesin thegh secret setcommand.
gh secret set -a codespaces IMAGE_VERSION --body "pr-${{ github.event.pull_request.number }}"
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
…s://github.com/philips-software/amp-devcontainer into feature/fix-acceptance-tests-on-default-branch
|
Pull Request Report (#824)Static measures
Time related measures
Status check related measures
|
|
🎉 Hooray! The changes in this pull request went live with the release of v6.1.0 🎉 |




🚀 Hey, I have created a Pull Request
Description of changes
This PR fixes the acceptance tests for non-PR branches and fix the annotations on the main image.
✔️ Checklist