Skip to content

ci: fix release job permissions #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjaegers merged 5 commits into from
Jun 24, 2025
Merged

ci: fix release job permissions #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb6bb4b
ci: fix release build job permissions
rjaegers Jun 20, 2025
daf43f3
ci: get rid of all 'secrets: inherit'
rjaegers Jun 20, 2025
cb3f1c7
Merge branch 'main' into feature/fix-release-build-job-permissions
rjaegers Jun 20, 2025
7c10b63
ci: specify secrets in reusable workflows
rjaegers Jun 20, 2025
2f54556
Merge branch 'main' into feature/fix-release-build-job-permissions
rjaegers Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ permissions: {}
jobs:
build-push-test:
uses: ./.github/workflows/wc-build-push-test.yml
secrets: inherit
secrets:
TEST_GITHUB_TOKEN: ${{ secrets.TEST_GITHUB_TOKEN }}
TEST_GITHUB_USER: ${{ secrets.TEST_GITHUB_USER }}
TEST_GITHUB_PASSWORD: ${{ secrets.TEST_GITHUB_PASSWORD }}
TEST_GITHUB_TOTP_SECRET: ${{ secrets.TEST_GITHUB_TOTP_SECRET }}
permissions:
actions: read
attestations: write
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ permissions: {}
jobs:
build-push-test:
uses: ./.github/workflows/wc-build-push-test.yml
secrets: inherit
secrets:
TEST_GITHUB_TOKEN: ${{ secrets.TEST_GITHUB_TOKEN }}
TEST_GITHUB_USER: ${{ secrets.TEST_GITHUB_USER }}
TEST_GITHUB_PASSWORD: ${{ secrets.TEST_GITHUB_PASSWORD }}
TEST_GITHUB_TOTP_SECRET: ${{ secrets.TEST_GITHUB_TOTP_SECRET }}
permissions:
actions: read
attestations: write
Expand All @@ -31,6 +35,8 @@ jobs:
enable-cache: false
apply-release-notes-template:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- uses: step-security/harden-runner@002fdce3c6a235733a90a27c80493a3241e56863 # v2.12.1
with:
Expand All @@ -54,6 +60,8 @@ jobs:
matrix:
flavor: [cpp, rust]
runs-on: ubuntu-latest
permissions:
contents: write
needs: [build-push-test, apply-release-notes-template]
env:
CONTAINER_FLAVOR: ${{ matrix.flavor }}
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/wc-acceptance-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ on:
flavor:
required: true
type: string
secrets:
TEST_GITHUB_TOKEN:
required: true
TEST_GITHUB_USER:
required: true
TEST_GITHUB_PASSWORD:
required: true
TEST_GITHUB_TOTP_SECRET:
required: true

concurrency:
group: ${{ github.workflow }}
Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/wc-build-push-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ on:
required: false
type: boolean
default: true
secrets:
TEST_GITHUB_TOKEN:
required: true
TEST_GITHUB_USER:
required: true
TEST_GITHUB_PASSWORD:
required: true
TEST_GITHUB_TOTP_SECRET:
required: true

permissions:
contents: read
Expand Down Expand Up @@ -55,7 +64,6 @@ jobs:
runner: ["ubuntu-latest", "ubuntu-24.04-arm"]
needs: build-push
uses: ./.github/workflows/wc-integration-test.yml
secrets: inherit
with:
flavor: ${{ matrix.flavor }}
runner: ${{ matrix.runner }}
Expand All @@ -66,7 +74,11 @@ jobs:
flavor: [cpp]
needs: build-push
uses: ./.github/workflows/wc-acceptance-test.yml
secrets: inherit
secrets:
TEST_GITHUB_TOKEN: ${{ secrets.TEST_GITHUB_TOKEN }}
TEST_GITHUB_USER: ${{ secrets.TEST_GITHUB_USER }}
TEST_GITHUB_PASSWORD: ${{ secrets.TEST_GITHUB_PASSWORD }}
TEST_GITHUB_TOTP_SECRET: ${{ secrets.TEST_GITHUB_TOTP_SECRET }}
with:
flavor: ${{ matrix.flavor }}

Expand Down
Loading