Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Jun 21, 2025

🚀 Hey, I have created a Pull Request

Description of changes

As was mentioned in the release notes of version 6.1.0 the docker cli is removed from amp-devcontainer-cpp.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings June 21, 2025 12:30
@rjaegers rjaegers requested a review from a team as a code owner June 21, 2025 12:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Docker CLI integration throughout the project.

  • Removes the integration test that verifies Docker CLI access.
  • Removes Docker socket mounting from both Rust and C++ devcontainer configurations.
  • Removes Docker CLI installation steps and related build arguments in the C++ Dockerfile.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/cpp/integration-tests.bats Removed test for Docker CLI functionality
.devcontainer/rust/devcontainer.json Removed Docker socket mount configuration
.devcontainer/cpp/devcontainer.json Removed Docker socket mount configuration
.devcontainer/cpp/Dockerfile Removed Docker CLI installation block and related build argument
Comments suppressed due to low confidence (3)

test/cpp/integration-tests.bats:190

  • The removal of the Docker CLI integration test is consistent with the PR’s objectives. Please ensure that any related documentation or comments are updated to reflect this change.
  assert_output "Hello World!"

.devcontainer/rust/devcontainer.json:8

  • The Docker socket mount has been removed from the Rust devcontainer configuration as expected. Verify that no development workflows depend on having Docker access from within the container.
    "CONTAINER_FLAVOR": "rust"

.devcontainer/cpp/Dockerfile:58

  • The Docker CLI installation block has been removed correctly; please confirm that there are no downstream dependencies that might require the Docker CLI to be present.
ENV PATH="$PATH:/opt/gcc-arm-none-eabi/bin"

@rjaegers rjaegers changed the title Feature/remove-docker-cli feat: remove docker cli from amp-devcontainer-cpp Jun 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edge to ghcr.io/philips-software/amp-devcontainer-rust:pr-832

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend
linux/amd64 481.29M 481.29M 0.00 (+0.00%) 🔄
linux/arm64 432.76M 432.76M 0.00 (+0.00%) 🔄

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 18 0 0 0.48s
✅ DOCKERFILE hadolint 2 0 0 0.89s
✅ GHERKIN gherkin-lint 2 0 0 0.99s
✅ JSON npm-package-json-lint yes no no 0.44s
✅ JSON prettier 16 1 0 0 0.44s
✅ JSON v8r 16 0 0 8.01s
✅ MARKDOWN markdownlint 9 0 0 0 0.93s
✅ MARKDOWN markdown-table-formatter 9 0 0 0 0.21s
✅ REPOSITORY checkov yes no no 17.73s
✅ REPOSITORY gitleaks yes no no 0.41s
✅ REPOSITORY git_diff yes no no 0.01s
⚠️ REPOSITORY grype yes no 2 23.59s
✅ REPOSITORY secretlint yes no no 0.99s
✅ REPOSITORY syft yes no no 2.0s
✅ REPOSITORY trivy yes no no 6.25s
✅ REPOSITORY trivy-sbom yes no no 0.23s
✅ REPOSITORY trufflehog yes no no 3.07s
✅ SPELL lychee 63 0 0 21.81s
✅ YAML prettier 24 0 0 0 0.86s
✅ YAML v8r 24 0 0 7.19s
✅ YAML yamllint 24 0 0 0.73s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edge to ghcr.io/philips-software/amp-devcontainer-cpp:pr-832

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend
linux/amd64 691.27M 673.57M (-2.56%) 🔽
linux/arm64 673.42M 656.71M (-2.48%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2025

Test Results

 4 files  ±0   4 suites  ±0   2m 22s ⏱️ -4s
30 tests  - 1  30 ✅  - 1  0 💤 ±0  0 ❌ ±0 
64 runs   - 2  64 ✅  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit 40fd228. ± Comparison against base commit fcc3527.

This pull request removes 1 test.
integration-tests.bats ‑ when the docker socket is mounted, using the docker cli should give access to the host docker daemon

♻️ This comment has been updated with latest results.

@rjaegers rjaegers enabled auto-merge (squash) June 24, 2025 08:56
@sonarqubecloud
Copy link

@rjaegers rjaegers merged commit eaa1c4e into main Jun 24, 2025
34 of 35 checks passed
@rjaegers rjaegers deleted the feature/remove-docker-cli branch June 24, 2025 09:38
@github-actions
Copy link
Contributor

Pull Request Report (#832)

Static measures

Description Value
Number of added lines 5
Number of deleted lines 23
Number of changed files 4
Number of commits 3
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 2.9 Days
Time that was spend on the branch before the PR was created 1.5 Min
Time that was spend on the branch before the PR was merged 2.9 Days
Time to merge after last review 1.2 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 34 Min
Total time spend in last status check run on PR 42.3 Min

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants