chore: image build improvements #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR removes unnecessary COPY statements by replacing them with bind mounts in the Dockerfiles to streamline file management during the build process.
- Updated the Rust Dockerfile to use a bind mount for the apt requirements file and cleaned up redundant environment variable declarations.
- Updated the C++ Dockerfile to use bind mounts for both apt requirements and Python requirements, along with the clang apt requirements file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .devcontainer/rust/Dockerfile | Replaces copy statements with bind mount; fixes redundant ENV usage and an incorrect file path. |
| .devcontainer/cpp/Dockerfile | Replaces copy statements with bind mount for apt and pip requirements and clang configuration. |
Contributor
Contributor
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 18 | 0 | 0 | 0.49s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.85s | |
| ✅ GHERKIN | gherkin-lint | 2 | 0 | 0 | 0.94s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.43s | |
| ✅ JSON | prettier | 16 | 1 | 0 | 0 | 0.57s |
| ✅ JSON | v8r | 16 | 0 | 0 | 7.54s | |
| ✅ MARKDOWN | markdownlint | 9 | 0 | 0 | 0 | 0.95s |
| ✅ MARKDOWN | markdown-table-formatter | 9 | 0 | 0 | 0 | 0.26s |
| ✅ REPOSITORY | checkov | yes | no | no | 17.02s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.41s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| grype | yes | no | 2 | 23.23s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 0.94s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.86s | |
| ✅ REPOSITORY | trivy | yes | no | no | 6.83s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.26s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.65s | |
| ✅ SPELL | lychee | 63 | 0 | 0 | 1.9s | |
| ✅ YAML | prettier | 24 | 0 | 0 | 0 | 0.94s |
| ✅ YAML | v8r | 24 | 0 | 0 | 6.66s | |
| ✅ YAML | yamllint | 24 | 0 | 0 | 0.82s |
See detailed report in MegaLinter reports
Contributor
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Don't source /etc/os-release but grep the value we want from it
rjaegers
changed the title
EkelmansPh
approved these changes
Jun 24, 2025
|
Contributor
Pull Request Report (#833)Static measures
Time related measures
Status check related measures
|
Contributor
|
🎉 Hooray! The changes in this pull request went live with the release of v6.2.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This PR contains a couple of (minor) image build improvements:
✔️ Checklist