Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Jun 23, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This PR adds preliminary, and very simple, document generation to amp-devcontainer.

It uses Gherkin feature files to describe requirements as Rules for a ground-truth that is close to the source-code and can be amended by Scenarios or Examples for test automation.

The feature files are converted to an intermediate format called SBDL and rendered, using a template document, to a PDF.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 20 0 0 0.61s
✅ DOCKERFILE hadolint 2 0 0 0.78s
✅ GHERKIN gherkin-lint 2 0 0 1.1s
✅ JSON npm-package-json-lint yes no no 0.46s
✅ JSON prettier 15 2 0 0 0.48s
✅ JSON v8r 15 0 0 7.24s
✅ MARKDOWN markdownlint 10 0 0 0 0.93s
✅ MARKDOWN markdown-table-formatter 10 0 0 0 0.22s
✅ REPOSITORY gitleaks yes no no 0.82s
✅ REPOSITORY git_diff yes no no 0.02s
⚠️ REPOSITORY grype yes no 1 27.66s
✅ REPOSITORY secretlint yes no no 0.99s
✅ REPOSITORY syft yes no no 1.94s
✅ REPOSITORY trivy yes no no 7.05s
✅ REPOSITORY trivy-sbom yes no no 0.25s
✅ REPOSITORY trufflehog yes no no 3.79s
✅ SPELL lychee 64 0 0 21.36s
✅ YAML prettier 26 0 0 0 0.91s
✅ YAML v8r 26 0 0 8.27s
✅ YAML yamllint 26 0 0 0.95s

Detailed Issues

⚠️ REPOSITORY / grype - 1 warning
warning: A medium vulnerability in python package: urllib3, version 1.26.20 was found at: /.devcontainer/cpp/requirements.txt

warning: 1 warnings emitted

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-841

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 696.53 MB 696.53 MB 866 B (0%) 🔽
linux/arm64 679.5 MB 679.5 MB 274 B (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-841

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 542.34 MB 542.34 MB 264 B (0%) 🔽
linux/arm64 498.79 MB 498.79 MB 282 B (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

Test Results

 4 files  ±0   4 suites  ±0   2m 24s ⏱️ -2s
30 tests ±0  30 ✅ ±0  0 💤 ±0  0 ❌ ±0 
64 runs  ±0  64 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8caaba2. ± Comparison against base commit 239fe97.

♻️ This comment has been updated with latest results.

@rjaegers rjaegers marked this pull request as ready for review September 25, 2025 06:26
@rjaegers rjaegers requested a review from a team as a code owner September 25, 2025 06:26
Copilot AI review requested due to automatic review settings September 25, 2025 06:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds preliminary document generation functionality to amp-devcontainer, using Gherkin feature files to describe requirements that are converted to SBDL format and rendered as PDF documents.

  • Restructures existing Gherkin feature files to use Rules format for better requirement specification
  • Adds Python script to extract rules from Gherkin files and convert them to CSV/SBDL format
  • Implements GitHub Actions workflow for automated document generation with PDF output

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/cpp/features/compilation.feature Restructured to use Gherkin Rules format with detailed compilation requirements
docs/templates/requirements.template.md Added Markdown template for rendering requirements document from SBDL data
docs/support/gherkin-to-csv.py Python script to parse Gherkin files and extract rules to CSV format
.github/workflows/wc-document-generation.yml New workflow for automated document generation using pandoc and LaTeX
.github/workflows/wc-build-push-test.yml Integration of document generation workflow into main build process

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 25, 2025 10:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 25, 2025 11:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

@rjaegers rjaegers merged commit 757e16a into main Sep 25, 2025
34 checks passed
@rjaegers rjaegers deleted the feature/document-generation branch September 25, 2025 13:30
@github-actions
Copy link
Contributor

Pull Request Report (#841)

Static measures

Description Value
Number of added lines 202
Number of deleted lines 13
Number of changed files 5
Number of commits 18
Number of reviews 5
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 4
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 7

Time related measures

Description Value
PR lead time (from creation to close of PR) 94 Days
Time that was spend on the branch before the PR was created 39 Sec
Time that was spend on the branch before the PR was merged 94 Days
Time to merge after last review 1.9 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 47 Min
Total time spend in last status check run on PR 14.6 Min

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2025

🎉 Hooray! The changes in this pull request went live with the release of v6.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants