Skip to content

Conversation

@rjaegers
Copy link
Member

🚀 Hey, I have created a Pull Request

Description of changes

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings June 27, 2025 17:18
@rjaegers rjaegers requested a review from a team as a code owner June 27, 2025 17:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Gherkin container flavor into the repository. The changes include new Gherkin feature tests, updates to multiple GitHub workflow files to include the new flavor, new devcontainer configuration files for Gherkin, and documentation updates in the README.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/gherkin/workspace/TestScenario.feature Added a comprehensive Gherkin feature file for shopping cart scenarios.
test/gherkin/integration-tests.bats Added a basic integration test for the Gherkin container.
README.md Updated documentation to include the Gherkin container flavor.
.github/workflows/*.yml Updated multiple workflow matrices to support the new gherkin flavor.
.devcontainer/gherkin/* Added new devcontainer configuration files for the Gherkin container.
.devcontainer/gherkin-test/devcontainer.json Added a test-specific devcontainer configuration for Gherkin.
Comments suppressed due to low confidence (1)

test/gherkin/integration-tests.bats:17

  • The integration test currently only lists the directory contents; consider adding assertions that verify key aspects of the Gherkin container functionality.
    ls -la

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-gherkin:edge to ghcr.io/philips-software/amp-devcontainer-gherkin:pr-846

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edge to ghcr.io/philips-software/amp-devcontainer-rust:pr-846

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend
linux/amd64 489.22M 489.22M 428.00 (+0.00%) 🔼
linux/arm64 441.18M 441.18M 913.00 (+0.00%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edge to ghcr.io/philips-software/amp-devcontainer-cpp:pr-846

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend
linux/amd64 657.00M 657.00M -768.00 (-0.00%) 🔽
linux/arm64 639.71M 639.71M -915.00 (-0.00%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 18 0 0 0.52s
✅ DOCKERFILE hadolint 3 0 0 0.96s
✅ GHERKIN gherkin-lint 3 0 0 1.28s
✅ JSON npm-package-json-lint yes no no 0.35s
✅ JSON prettier 20 1 0 0 0.49s
✅ JSON v8r 20 0 0 7.87s
✅ MARKDOWN markdownlint 9 0 0 0 0.85s
✅ MARKDOWN markdown-table-formatter 9 0 0 0 0.26s
✅ REPOSITORY checkov yes no no 16.0s
✅ REPOSITORY gitleaks yes no no 0.4s
✅ REPOSITORY git_diff yes no no 0.01s
⚠️ REPOSITORY grype yes no 1 23.37s
✅ REPOSITORY secretlint yes no no 0.94s
✅ REPOSITORY syft yes no no 2.01s
✅ REPOSITORY trivy yes no no 5.42s
✅ REPOSITORY trivy-sbom yes no no 0.23s
✅ REPOSITORY trufflehog yes no no 3.83s
✅ SPELL lychee 67 0 0 2.74s
✅ YAML prettier 24 0 0 0 0.8s
✅ YAML v8r 24 0 0 5.7s
✅ YAML yamllint 24 0 0 0.82s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

Test Results

 6 files  +2   6 suites  +2   2m 26s ⏱️ ±0s
31 tests +1  31 ✅ +1  0 💤 ±0  0 ❌ ±0 
66 runs  +2  66 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 8f94124. ± Comparison against base commit 32c3dee.

♻️ This comment has been updated with latest results.

@rjaegers rjaegers marked this pull request as draft June 30, 2025 10:55
rjaegers added 2 commits July 1, 2025 05:35
Eventually we will need to exclude this folder with test-data, or specific files, because we also want to test failure cases.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

This pull request is marked stale because it has been open for an extended period with no activity. Remove the 'stale' label or comment otherwise this pull request will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 6, 2025
@rjaegers rjaegers removed the stale label Sep 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

This pull request is marked stale because it has been open for an extended period with no activity. Remove the 'stale' label or comment otherwise this pull request will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 9, 2025
@github-actions github-actions bot closed this Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants