-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add gherkin container flavor #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new Gherkin container flavor into the repository. The changes include new Gherkin feature tests, updates to multiple GitHub workflow files to include the new flavor, new devcontainer configuration files for Gherkin, and documentation updates in the README.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/gherkin/workspace/TestScenario.feature | Added a comprehensive Gherkin feature file for shopping cart scenarios. |
| test/gherkin/integration-tests.bats | Added a basic integration test for the Gherkin container. |
| README.md | Updated documentation to include the Gherkin container flavor. |
| .github/workflows/*.yml | Updated multiple workflow matrices to support the new gherkin flavor. |
| .devcontainer/gherkin/* | Added new devcontainer configuration files for the Gherkin container. |
| .devcontainer/gherkin-test/devcontainer.json | Added a test-specific devcontainer configuration for Gherkin. |
Comments suppressed due to low confidence (1)
test/gherkin/integration-tests.bats:17
- The integration test currently only lists the directory contents; consider adding assertions that verify key aspects of the Gherkin container functionality.
ls -la
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 18 | 0 | 0 | 0.52s | |
| ✅ DOCKERFILE | hadolint | 3 | 0 | 0 | 0.96s | |
| ✅ GHERKIN | gherkin-lint | 3 | 0 | 0 | 1.28s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.35s | |
| ✅ JSON | prettier | 20 | 1 | 0 | 0 | 0.49s |
| ✅ JSON | v8r | 20 | 0 | 0 | 7.87s | |
| ✅ MARKDOWN | markdownlint | 9 | 0 | 0 | 0 | 0.85s |
| ✅ MARKDOWN | markdown-table-formatter | 9 | 0 | 0 | 0 | 0.26s |
| ✅ REPOSITORY | checkov | yes | no | no | 16.0s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.4s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| grype | yes | no | 1 | 23.37s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 0.94s | |
| ✅ REPOSITORY | syft | yes | no | no | 2.01s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.42s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.23s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.83s | |
| ✅ SPELL | lychee | 67 | 0 | 0 | 2.74s | |
| ✅ YAML | prettier | 24 | 0 | 0 | 0 | 0.8s |
| ✅ YAML | v8r | 24 | 0 | 0 | 5.7s | |
| ✅ YAML | yamllint | 24 | 0 | 0 | 0.82s |
See detailed report in MegaLinter reports
Eventually we will need to exclude this folder with test-data, or specific files, because we also want to test failure cases.
|
|
This pull request is marked stale because it has been open for an extended period with no activity. Remove the 'stale' label or comment otherwise this pull request will be closed in 7 days. |
|
This pull request is marked stale because it has been open for an extended period with no activity. Remove the 'stale' label or comment otherwise this pull request will be closed in 7 days. |




🚀 Hey, I have created a Pull Request
Description of changes
✔️ Checklist