-
Notifications
You must be signed in to change notification settings - Fork 7
ci: disable docker image cache #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Docker image cache was invaluable when the ARM build was still emulated. Now that all builds are run on native hardware the build time has reduced significantly. As such the cache is doing more harm than it is useful. Leading to invalid Dockerfiles ending up on the default branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes Docker image cache functionality from the CI/CD workflows, as the cache is no longer beneficial with native ARM builds and may cause issues with invalid Dockerfiles reaching the default branch.
- Removes
enable-cacheinput parameter from workflow definitions - Eliminates Docker cache configuration from build steps
- Cleans up cache-related parameters passed between workflows
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/wc-build-push.yml |
Removes cache input parameter and Docker cache-to/cache-from configurations |
.github/workflows/wc-build-push-test.yml |
Removes cache input parameter and its usage in workflow calls |
.github/workflows/release-build.yml |
Removes explicit cache disabling since the parameter no longer exists |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 19 | 0 | 0 | 0.64s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.74s | |
| ✅ GHERKIN | gherkin-lint | 2 | 0 | 0 | 1.01s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.45s | |
| ✅ JSON | prettier | 15 | 2 | 0 | 0 | 0.52s |
| ✅ JSON | v8r | 15 | 0 | 0 | 7.26s | |
| ✅ MARKDOWN | markdownlint | 9 | 0 | 0 | 0 | 0.94s |
| ✅ MARKDOWN | markdown-table-formatter | 9 | 0 | 0 | 0 | 0.33s |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.94s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.02s | |
| grype | yes | no | 1 | 27.63s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 1.0s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.93s | |
| ✅ REPOSITORY | trivy | yes | no | no | 6.97s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.24s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.84s | |
| ✅ SPELL | lychee | 62 | 0 | 0 | 1.76s | |
| ✅ YAML | prettier | 25 | 0 | 0 | 0 | 1.06s |
| ✅ YAML | v8r | 25 | 0 | 0 | 7.94s | |
| ✅ YAML | yamllint | 25 | 0 | 0 | 0.99s |
Detailed Issues
⚠️ REPOSITORY / grype - 1 warning
warning: A medium vulnerability in python package: urllib3, version 1.26.20 was found at: /.devcontainer/cpp/requirements.txt
warning: 1 warnings emitted
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Pull Request Report (#943)Static measures
Time related measures
Status check related measures
|
|
🎉 Hooray! The changes in this pull request went live with the release of v6.5.0 🎉 |




🚀 Hey, I have created a Pull Request
Description of changes
The pendulum swings towards no cache 🔀.
The Docker image cache was invaluable when the ARM build was still emulated. Now that all builds are run on native hardware the build time has reduced significantly. As such the cache is doing more harm than it is useful. Leading to invalid Dockerfiles ending up on the default branch and invalid size metrics being reported in pull requests.
This PR removes the use of the Docker build cache, adding a bit of build time in favor of better stability and reproducibility.
✔️ Checklist