Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Sep 25, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This PR updates the documentation generation by:

  • Cutting out CSV as the middle-man; we now go directly from Gherkin to SBDL giving us more control (at the cost of slightly more/complex conversion logic)
  • Adding the generated document(s) to the release
  • Updating/adding several requirements (copied over partly from a stale branch)

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner September 25, 2025 17:44
Copilot AI review requested due to automatic review settings September 25, 2025 17:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces document generation capabilities by extracting requirements from Gherkin feature files and converting them to documentation formats. The implementation includes a Python script to parse feature files and generate SBDL format output, along with GitHub workflow automation.

  • Added Python script to convert Gherkin feature files to SBDL format requirements
  • Created Jinja2 template for generating requirements documentation
  • Integrated document generation into GitHub Actions workflow

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/cpp/features/compilation.feature Enhanced feature file with structured rules and detailed requirements for compilation scenarios
docs/templates/requirements.md.j2 Jinja2 template for generating requirements documentation from SBDL data
docs/support/gherkin-to-sbdl.py Python script to parse Gherkin features and convert to SBDL format
.github/workflows/wc-document-generation.yml GitHub workflow for automated document generation
.github/workflows/wc-build-push-test.yml Integration of document generation into main build workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 20 0 0 0.57s
✅ DOCKERFILE hadolint 2 0 0 0.79s
✅ GHERKIN gherkin-lint 6 0 0 2.31s
✅ JSON npm-package-json-lint yes no no 0.49s
✅ JSON prettier 15 2 0 0 0.48s
✅ JSON v8r 15 0 0 7.04s
✅ MARKDOWN markdownlint 10 0 0 0 0.94s
✅ MARKDOWN markdown-table-formatter 10 0 0 0 0.2s
✅ REPOSITORY gitleaks yes no no 0.91s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 27.32s
✅ REPOSITORY secretlint yes no no 0.97s
✅ REPOSITORY syft yes no no 1.85s
✅ REPOSITORY trivy yes no no 7.15s
✅ REPOSITORY trivy-sbom yes no no 0.24s
✅ REPOSITORY trufflehog yes no no 3.4s
✅ SPELL lychee 70 0 0 9.67s
✅ YAML prettier 26 0 0 0 1.07s
✅ YAML v8r 26 0 0 7.44s
✅ YAML yamllint 26 0 0 0.87s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-946

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 544.75 MB 544.75 MB 103 B (0%) 🔽
linux/arm64 501 MB 501 MB +404 B (+0%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-946

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 698.92 MB 698.92 MB +638 B (+0%) 🔼
linux/arm64 681.73 MB 681.73 MB +357 B (+0%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Test Results

 5 files  ±0   5 suites  ±0   3m 44s ⏱️ +15s
31 tests ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 
65 runs  ±0  65 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0336d46. ± Comparison against base commit 342e2b1.

♻️ This comment has been updated with latest results.

Copilot AI review requested due to automatic review settings October 4, 2025 07:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings October 4, 2025 07:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ron <[email protected]>
Copilot AI review requested due to automatic review settings October 4, 2025 07:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

.github/workflows/wc-document-generation.yml:1

  • The artifact download pattern should be more specific. Use 'documents-*' or the exact artifact name to avoid potential conflicts with other artifacts.
---

@rjaegers rjaegers enabled auto-merge October 4, 2025 08:38
@rjaegers rjaegers added this pull request to the merge queue Oct 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 4, 2025
Copilot AI review requested due to automatic review settings October 5, 2025 08:01
@rjaegers rjaegers enabled auto-merge October 5, 2025 08:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 10 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rjaegers rjaegers added this pull request to the merge queue Oct 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 5, 2025
@rjaegers rjaegers added this pull request to the merge queue Oct 5, 2025
Merged via the queue into main with commit a1129b5 Oct 5, 2025
34 of 35 checks passed
@rjaegers rjaegers deleted the feature/document-generation-additions branch October 5, 2025 09:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2025

Pull Request Report (#946)

Static measures

Description Value
Number of added lines 555
Number of deleted lines 140
Number of changed files 17
Number of commits 45
Number of reviews 25
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 24
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 8

Time related measures

Description Value
PR lead time (from creation to close of PR) 9.7 Days
Time that was spend on the branch before the PR was created 94.2 Days
Time that was spend on the branch before the PR was merged 103.9 Days
Time to merge after last review 1 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 34.6 Min
Total time spend in last status check run on PR 46 Min

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2025

🎉 Hooray! The changes in this pull request went live with the release of v6.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants