-
Notifications
You must be signed in to change notification settings - Fork 7
ci: improvements to speed and robustness #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves CI pipeline efficiency and robustness by optimizing build triggers, enhancing test reporting, and updating dependencies.
- Removes unnecessary builds on main branch pushes now that merge queue is enabled
- Integrates acceptance test results into the unified test reporting system
- Updates Node.js to latest version in acceptance test workflow
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/continuous-integration.yml | Removes push trigger on main branch to prevent unnecessary builds |
| .github/workflows/wc-build-push.yml | Optimizes Docker tag generation to only build edge tags during merge queue events |
| .github/workflows/wc-acceptance-test.yml | Updates Node.js version and configures JUnit test result output |
| .github/workflows/wc-integration-test.yml | Updates artifact naming for consistency with acceptance tests |
| test/cpp/features/playwright.config.ts | Configures JUnit reporter for CI environments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 20 | 0 | 0 | 0.61s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.78s | |
| ✅ GHERKIN | gherkin-lint | 2 | 0 | 0 | 1.13s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.52s | |
| ✅ JSON | prettier | 15 | 2 | 0 | 0 | 0.54s |
| ✅ JSON | v8r | 15 | 0 | 0 | 8.54s | |
| ✅ MARKDOWN | markdownlint | 11 | 0 | 0 | 0 | 0.94s |
| ✅ MARKDOWN | markdown-table-formatter | 11 | 0 | 0 | 0 | 0.24s |
| ✅ REPOSITORY | gitleaks | yes | no | no | 1.05s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| grype | yes | no | 1 | 28.37s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 1.05s | |
| ✅ REPOSITORY | syft | yes | no | no | 2.02s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.09s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.25s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.54s | |
| ✅ SPELL | lychee | 65 | 0 | 0 | 3.23s | |
| ✅ YAML | prettier | 26 | 0 | 0 | 0 | 0.9s |
| ✅ YAML | v8r | 26 | 0 | 0 | 8.55s | |
| ✅ YAML | yamllint | 26 | 0 | 0 | 1.08s |
Detailed Issues
⚠️ REPOSITORY / grype - 1 warning
warning: A medium vulnerability in python package: urllib3, version 1.26.20 was found at: /.devcontainer/cpp/requirements.txt
warning: 1 warnings emitted
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
…ips-software/amp-devcontainer into ci/reduce-build-duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Ron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
|
Pull Request Report (#954)Static measures
Time related measures
Status check related measures
|
|
🎉 Hooray! The changes in this pull request went live with the release of v6.5.0 🎉 |




🚀 Hey, I have created a Pull Request
Description of changes
This PR improves on some aspects of ci:
✔️ Checklist