Skip to content

Conversation

@rjaegers
Copy link
Member

🚀 Hey, I have created a Pull Request

Description of changes

This PR improves on some aspects of ci:

  • Remove unnecessary build of main (leading to edge tag) now that the merge queue is enabled
  • Include acceptance tests (Playwright) in Test Results check
  • Update node to latest release in acceptance test workflow

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner September 30, 2025 11:25
Copilot AI review requested due to automatic review settings September 30, 2025 11:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves CI pipeline efficiency and robustness by optimizing build triggers, enhancing test reporting, and updating dependencies.

  • Removes unnecessary builds on main branch pushes now that merge queue is enabled
  • Integrates acceptance test results into the unified test reporting system
  • Updates Node.js to latest version in acceptance test workflow

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/continuous-integration.yml Removes push trigger on main branch to prevent unnecessary builds
.github/workflows/wc-build-push.yml Optimizes Docker tag generation to only build edge tags during merge queue events
.github/workflows/wc-acceptance-test.yml Updates Node.js version and configures JUnit test result output
.github/workflows/wc-integration-test.yml Updates artifact naming for consistency with acceptance tests
test/cpp/features/playwright.config.ts Configures JUnit reporter for CI environments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 20 0 0 0.61s
✅ DOCKERFILE hadolint 2 0 0 0.78s
✅ GHERKIN gherkin-lint 2 0 0 1.13s
✅ JSON npm-package-json-lint yes no no 0.52s
✅ JSON prettier 15 2 0 0 0.54s
✅ JSON v8r 15 0 0 8.54s
✅ MARKDOWN markdownlint 11 0 0 0 0.94s
✅ MARKDOWN markdown-table-formatter 11 0 0 0 0.24s
✅ REPOSITORY gitleaks yes no no 1.05s
✅ REPOSITORY git_diff yes no no 0.01s
⚠️ REPOSITORY grype yes no 1 28.37s
✅ REPOSITORY secretlint yes no no 1.05s
✅ REPOSITORY syft yes no no 2.02s
✅ REPOSITORY trivy yes no no 5.09s
✅ REPOSITORY trivy-sbom yes no no 0.25s
✅ REPOSITORY trufflehog yes no no 2.54s
✅ SPELL lychee 65 0 0 3.23s
✅ YAML prettier 26 0 0 0 0.9s
✅ YAML v8r 26 0 0 8.55s
✅ YAML yamllint 26 0 0 1.08s

Detailed Issues

⚠️ REPOSITORY / grype - 1 warning
warning: A medium vulnerability in python package: urllib3, version 1.26.20 was found at: /.devcontainer/cpp/requirements.txt

warning: 1 warnings emitted

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-954

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 542.34 MB 542.34 MB 644 B (0%) 🔽
linux/arm64 498.79 MB 498.79 MB +499 B (+0%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-954

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 696.54 MB 696.54 MB 235 B (0%) 🔽
linux/arm64 679.52 MB 679.52 MB 643 B (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Test Results

 5 files  +1   5 suites  +1   3m 26s ⏱️ +54s
31 tests +1  31 ✅ +1  0 💤 ±0  0 ❌ ±0 
65 runs  +1  65 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 8bfb78f. ± Comparison against base commit 2e2a537.

♻️ This comment has been updated with latest results.

Copilot AI review requested due to automatic review settings September 30, 2025 11:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings September 30, 2025 11:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@sonarqubecloud
Copy link

@rjaegers rjaegers added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit bcf8952 Sep 30, 2025
34 checks passed
@rjaegers rjaegers deleted the ci/reduce-build-duplication branch September 30, 2025 13:54
@github-actions
Copy link
Contributor

Pull Request Report (#954)

Static measures

Description Value
Number of added lines 12
Number of deleted lines 10
Number of changed files 5
Number of commits 7
Number of reviews 4
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 3
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 2.5 Hours
Time that was spend on the branch before the PR was created 22.6 Min
Time that was spend on the branch before the PR was merged 2.9 Hours
Time to merge after last review 12 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 37.3 Min
Total time spend in last status check run on PR 13.7 Min

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2025

🎉 Hooray! The changes in this pull request went live with the release of v6.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants