ci: fix zizmor findings #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR hardens GitHub Actions security by replacing third-party action dependencies with native GitHub CLI commands for PR comment management. The changes eliminate external action dependencies while maintaining the same functionality for posting and removing PR title validation comments.
- Replaced
marocchino/sticky-pull-request-commentaction with nativeghCLI commands - Added explicit permission documentation for clarity
- Implemented proper sticky comment functionality using HTML markers and GitHub API
Rely on the content in the README, CONTRIBUTING and GitHubs native functionality surrounding that documentation to help first-time contributers.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Ron <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 21 | 0 | 0 | 0.54s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.78s | |
| ✅ GHERKIN | gherkin-lint | 6 | 0 | 0 | 2.41s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.46s | |
| ✅ JSON | prettier | 15 | 2 | 0 | 0 | 0.54s |
| ✅ JSON | v8r | 15 | 0 | 0 | 7.97s | |
| ✅ MARKDOWN | markdownlint | 11 | 0 | 0 | 0 | 0.85s |
| ✅ MARKDOWN | markdown-table-formatter | 11 | 0 | 0 | 0 | 0.24s |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.97s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 28.88s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 1.01s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.99s | |
| ✅ REPOSITORY | trivy | yes | no | no | 4.81s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.25s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.03s | |
| lychee | 72 | 2 | 0 | 13.85s | ||
| ✅ YAML | prettier | 27 | 0 | 0 | 0 | 1.28s |
| ✅ YAML | v8r | 27 | 0 | 0 | 8.39s | |
| ✅ YAML | yamllint | 27 | 0 | 0 | 0.78s |
Detailed Issues
⚠️ SPELL / lychee - 2 errors
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/)
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Error (cached)
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........122
✅ Successful.....118
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........2
Errors in .github/CONTRIBUTING.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/)
Errors in README.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Error (cached)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
Co-authored-by: Copilot <[email protected]> Signed-off-by: Ron <[email protected]>
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
|
Contributor
Pull Request Report (#967)Static measures
Time related measures
Status check related measures
|
Contributor
|
🎉 Hooray! The changes in this pull request went live with the release of v6.5.3 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This pull request focuses on improving the clarity and maintainability of GitHub workflow and configuration files. The key changes include adding explicit comments to workflow permissions that describe their necessity for specific actions, introducing cooldown periods for Dependabot updates, and updating workflow actions and logic for better reliability and readability.
Workflow permission documentation and improvements:
Dependabot configuration enhancements:
cooldownperiod of 7 days for all package ecosystems in.github/dependabot.ymlto reduce the frequency of update PRs and help manage update noise. [1] [2] [3]Workflow logic and action updates:
reviewdog/action-suggesterin.github/workflows/linting-formatting.ymlto v1.24.0 for improved features and reliability..github/workflows/wc-acceptance-test.ymlfor better readability and future extensibility, and improved secret setting logic.Workflow structure and cleanup:
.github/workflows/social-interaction.ymlworkflow, likely to streamline workflow management and reduce unnecessary automation.General workflow permission structure:
permissions: {}) in workflow files where no global permissions are needed, supporting the principle of least privilege. (.github/workflows/linting-formatting.yml, .github/workflows/ossf-scorecard.yml, .github/workflows/release-please.yml) [1] [2] [3]✔️ Checklist