ci: fix using sequences in job names #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes GitHub Actions workflow runner label handling by requiring all runner labels to be passed as JSON arrays, removing the previous fallback logic that supported both plain strings and JSON arrays.
Key Changes:
- Removed conditional logic that detected JSON arrays vs plain strings in
runs-onfields - Updated all
runner-labelsinputs to require valid JSON array format with updated descriptions - Changed default values from plain strings (e.g.,
ubuntu-latest) to JSON arrays (e.g.,["ubuntu-latest"])
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/wc-sanitize-image-name.yml |
Simplified runs-on to always use fromJson() without conditional checks |
.github/workflows/wc-integration-test.yml |
Removed description and simplified runs-on field |
.github/workflows/wc-dependency-review.yml |
Updated input description, changed default to JSON array format, simplified runs-on |
.github/workflows/wc-build-push.yml |
Simplified runs-on fields, updated job name formatting, removed unnecessary checkout step |
.github/workflows/wc-build-push-test.yml |
Updated input descriptions to clarify JSON array requirement, changed defaults to JSON arrays |
.github/workflows/continuous-integration.yml |
Removed emoji from job name |
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 22 | 0 | 0 | 0.5s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.75s | |
| ✅ GHERKIN | gherkin-lint | 6 | 0 | 0 | 2.32s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.44s | |
| ✅ JSON | prettier | 15 | 2 | 0 | 0 | 0.48s |
| ✅ JSON | v8r | 15 | 0 | 0 | 7.25s | |
| ✅ MARKDOWN | markdownlint | 11 | 0 | 0 | 0 | 0.9s |
| ✅ MARKDOWN | markdown-table-formatter | 11 | 0 | 0 | 0 | 0.23s |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.97s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 28.43s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 1.0s | |
| ✅ REPOSITORY | syft | yes | no | no | 2.0s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.46s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.25s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.37s | |
| lychee | 73 | 1 | 0 | 13.49s | ||
| ✅ YAML | prettier | 28 | 0 | 0 | 0 | 1.2s |
| ✅ YAML | v8r | 28 | 0 | 0 | 8.05s | |
| ✅ YAML | yamllint | 28 | 0 | 0 | 0.94s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?
📝 Summary
---------------------
🔍 Total..........122
✅ Successful.....119
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
Errors in .github/CONTRIBUTING.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
andjordan
approved these changes
Oct 16, 2025
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Pull Request Report (#980)Static measures
Time related measures
Status check related measures
|
Contributor
|
🎉 Hooray! The changes in this pull request went live with the release of v6.5.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This pull request refactors several GitHub Actions workflow files to standardize the way runner labels are handled and improve documentation for workflow inputs. The main focus is on consistently using JSON arrays for runner labels, simplifying matrix definitions, and enhancing input descriptions for clarity. These changes help reduce ambiguity, make the workflows easier to maintain, and improve support for multi-architecture and self-hosted runners.
Standardization of runner label handling:
wc-build-push.yml,wc-build-push-test.yml,wc-dependency-review.yml,wc-integration-test.yml,wc-sanitize-image-name.yml) to consistently parse runner labels from JSON arrays usingfromJson, removing previous logic that handled both plain strings and arrays. This ensures uniform runner selection and simplifies the code. [1] [2] [3] [4]Improvements to workflow input documentation:
wc-build-push-test.yml,wc-dependency-review.yml) to provide clear examples and clarify expected formats for runner labels, Docker registry, image names, and devcontainer metadata files. This helps users understand how to configure workflows correctly. [1] [2]Matrix and strategy simplification:
Security and permissions adjustments:
Minor workflow cleanups:
actions/checkoutinwc-build-push.yml) and made minor naming adjustments for job clarity. [1] [2]Let me know if you'd like to see how these changes affect a specific workflow or if you have questions about multi-architecture runner support!
✔️ Checklist