-
Notifications
You must be signed in to change notification settings - Fork 7
fix: attestation verification for repos that re-use amp-devcontainer workflows #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…evcontainer workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds explicit signer workflow reference to attestation verification so downstream repositories using the reusable build/push workflow can successfully verify image attestations.
- Introduces --signer-workflow flag to gh attestation verify command.
- Targets canonical workflow path to align verification with reusable workflow origin.
|
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
…workflows (#987) fix: enable attestation verification to pass for repos that use amp-devcontainer workflows
Pull Request Report (#987)Static measures
Time related measures
Status check related measures
|
|
🎉 Hooray! The changes in this pull request went live with the release of v6.5.2 🎉 |




🚀 Hey, I have created a Pull Request
Description of changes
This pull request updates the attestation verification step in the
.github/workflows/wc-build-push.ymlworkflow to improve security and traceability.Security and attestation verification:
Verify attestationstep now explicitly specifies the--signer-workflowparameter, referencing thephilips-software/amp-devcontainer/.github/workflows/wc-build-push.ymlworkflow for signer verification. This ensures that attestations are only accepted from trusted workflows and enhances the provenance of built images.✔️ Checklist