Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Oct 22, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This PR fixes the broken document generation for releases after the recent workflow refactoring. During the release build no document were generated because of a missing step, and thus the publishing of documents failed.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner October 22, 2025 12:38
Copilot AI review requested due to automatic review settings October 22, 2025 12:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds document generation as a separate step in the release workflow. The change refactors the existing document handling by introducing a new generate-documents job that calls a reusable workflow, while updating the upload-documents job to depend on this new job instead of the broader build-push-test job.

  • Introduces a new generate-documents job that delegates to wc-document-generation.yml
  • Updates the upload-documents job dependency from build-push-test to generate-documents

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 22 0 0 0.45s
✅ DOCKERFILE hadolint 2 0 0 0.79s
✅ GHERKIN gherkin-lint 6 0 0 2.27s
✅ JSON npm-package-json-lint yes no no 0.48s
✅ JSON prettier 15 2 0 0 0.54s
✅ JSON v8r 15 0 0 7.19s
✅ MARKDOWN markdownlint 11 0 0 0 0.89s
✅ MARKDOWN markdown-table-formatter 11 0 0 0 0.21s
✅ REPOSITORY gitleaks yes no no 0.92s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 28.18s
✅ REPOSITORY secretlint yes no no 0.98s
✅ REPOSITORY syft yes no no 1.96s
✅ REPOSITORY trivy yes no no 5.65s
✅ REPOSITORY trivy-sbom yes no no 0.24s
✅ REPOSITORY trufflehog yes no no 2.38s
⚠️ SPELL lychee 73 1 0 23.44s
✅ YAML prettier 28 0 0 0 1.17s
✅ YAML v8r 28 0 0 8.12s
✅ YAML yamllint 28 0 0 0.92s

Detailed Issues

⚠️ SPELL / lychee - 1 error
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[ERROR] https://slsa.dev/spec/v1.0/threats | Network error: error sending request for url (https://slsa.dev/spec/v1.0/threats) Maybe a certificate error?
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........122
✅ Successful.....119
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in test/cpp/features/security.feature
[ERROR] https://slsa.dev/spec/v1.0/threats | Network error: error sending request for url (https://slsa.dev/spec/v1.0/threats) Maybe a certificate error?

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-989

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 536.92 MB 536.92 MB 238 B (0%) 🔽
linux/arm64 493.6 MB 493.6 MB 150 B (0%) 🔽

@github-actions
Copy link
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-989

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 691.12 MB 691.12 MB +316 B (+0%) 🔼
linux/arm64 674.34 MB 674.34 MB +445 B (+0%) 🔼

@github-actions
Copy link
Contributor

Test Results

 5 files  ±0   5 suites  ±0   3m 44s ⏱️ +13s
31 tests ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 
65 runs  ±0  65 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 40dc99f. ± Comparison against base commit c955537.

@rjaegers rjaegers changed the title ci: add document generation to release ci: re-add document generation to release Oct 22, 2025
@magi-arun magi-arun requested a review from andjordan October 23, 2025 07:10
@rjaegers rjaegers added this pull request to the merge queue Oct 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 23, 2025
@rjaegers rjaegers added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 7868142 Oct 23, 2025
36 checks passed
@rjaegers rjaegers deleted the ci/fix-release-document-generation branch October 23, 2025 12:20
@github-actions
Copy link
Contributor

Pull Request Report (#989)

Static measures

Description Value
Number of added lines 6
Number of deleted lines 1
Number of changed files 1
Number of commits 1
Number of reviews 3
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 2
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 23.7 Hours
Time that was spend on the branch before the PR was created 21 Sec
Time that was spend on the branch before the PR was merged 23.7 Hours
Time to merge after last review 2.5 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 41.2 Min
Total time spend in last status check run on PR 5.8 Hours

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.5.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants