feat: add Stop to FlashEcho #1071
Merged
+119
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your first PR. We really appreciate it! |
Contributor
Dependency ReviewThe following issues were found:
Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issuesexternal/protobuf/CMakeLists.txt
external/args/CMakeLists.txt
external/crypto/mbedtls/CMakeLists.txt
external/crypto/micro-ecc/CMakeLists.txt
external/crypto/tiny-aes128/CMakeLists.txt
osal/freertos/CMakeLists.txt
cmake/emil_test_helpers.cmake
osal/threadx/CMakeLists.txt
lwip/lwip/CMakeLists.txt
external/segger_rtt/CMakeLists.txt
infra/syntax/CMakeLists.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0 | 0.29s | |
| ✅ CPP | clang-format | 1054 | 7 | 0 | 0 | 7.98s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.32s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.17s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.56s |
| markdownlint | 6 | 0 | 4 | 0 | 1.36s | |
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0 | 0.32s |
| ✅ REPOSITORY | checkov | yes | no | no | 20.82s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.05s | |
| ✅ REPOSITORY | grype | yes | no | no | 28.06s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.07s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 7.85s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.42s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.27s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.18s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.31s | |
| lychee | 139 | 1 | 0 | 21.45s | ||
| prettier | 22 | 1 | 1 | 0 | 0.73s | |
| ✅ YAML | v8r | 22 | 0 | 0 | 6.42s | |
| ✅ YAML | yamllint | 22 | 0 | 0 | 0.62s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip | Network error: Not Found
📝 Summary
---------------------
🔍 Total..........544
✅ Successful.....540
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........3
❓ Unknown..........0
🚫 Errors...........1
Errors in external/protoc/CMakeLists.txt
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip | Network error: Not Found
⚠️ MARKDOWN / markdownlint - 4 errors
external/crypto/tiny-aes128/README.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "### Tiny AES128 in C"]
external/crypto/tiny-aes128/README.md:29 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:39 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:49 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
⚠️ YAML / prettier - 1 error
[error] Explicitly specified pattern "documents/modules/ROOT/examples/clangformat.yaml" is a symbolic link.
.clusterfuzzlite/project.yaml 34ms (unchanged)
.github/dependabot.yml 13ms (unchanged)
.github/workflows/ci.yml 85ms (unchanged)
.github/workflows/dependency-scanner.yml 13ms (unchanged)
.github/workflows/documentation.yml 16ms (unchanged)
.github/workflows/fuzzing-batch.yml 11ms (unchanged)
.github/workflows/fuzzing-cron.yml 7ms (unchanged)
.github/workflows/fuzzing-pr.yml 7ms (unchanged)
.github/workflows/linting-formatting.yml 19ms (unchanged)
.github/workflows/release-please.yml 9ms (unchanged)
.github/workflows/security.yml 9ms (unchanged)
.github/workflows/social-interaction.yml 7ms (unchanged)
.github/workflows/static-analysis.yml 6ms (unchanged)
.github/workflows/validate-pr.yml 8ms (unchanged)
.ls-lint.yml 2ms
.mega-linter.yml 2ms (unchanged)
antora-playbook-branch.yml 3ms (unchanged)
antora-playbook-site.yml 2ms (unchanged)
documents/antora.yml 3ms (unchanged)
documents/supplemental-ui/ui.yml 1ms (unchanged)
mull.yml 2ms (unchanged)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
andjordan
approved these changes
Jan 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Stop() capability to FlashEcho and expands unit tests to cover stopping while idle and during in-flight flash operations.
Changes:
- Added
FlashEcho::Stop()API and internal stop/busy state. - Updated
FlashEchoread/write/erase completion paths to honor stop requests. - Extended
TestFlashEcho.cppwith stop-related test cases and renamed the fixture.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| services/util/test/TestFlashEcho.cpp | Renames the test fixture and adds coverage for Stop() in idle + in-flight scenarios. |
| services/util/FlashEcho.hpp | Declares Stop() and introduces busy + onStopped state. |
| services/util/FlashEcho.cpp | Implements Stop() and integrates stop handling into flash operation callbacks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.