fix: standard include directories in Windows toolchain file #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your first PR. We really appreciate it! |
Contributor
Dependency ReviewThe following issues were found:
Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issueslwip/lwip/CMakeLists.txt
osal/threadx/CMakeLists.txt
external/segger_rtt/CMakeLists.txt
infra/syntax/CMakeLists.txt
external/crypto/tiny-aes128/CMakeLists.txt
osal/freertos/CMakeLists.txt
external/crypto/micro-ecc/CMakeLists.txt
external/crypto/mbedtls/CMakeLists.txt
external/protobuf/CMakeLists.txt
cmake/emil_test_helpers.cmake
external/args/CMakeLists.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0 | 0.29s | |
| ✅ CPP | clang-format | 1053 | 7 | 0 | 0 | 8.17s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.3s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.18s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.69s |
| markdownlint | 6 | 0 | 4 | 0 | 1.6s | |
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0 | 0.41s |
| ✅ REPOSITORY | checkov | yes | no | no | 21.37s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.05s | |
| ✅ REPOSITORY | grype | yes | no | no | 27.78s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.07s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 8.23s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.39s | |
| ✅ REPOSITORY | trivy | yes | no | no | 6.01s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.2s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.37s | |
| lychee | 139 | 1 | 0 | 5.64s | ||
| prettier | 22 | 1 | 1 | 0 | 1.02s | |
| ✅ YAML | v8r | 22 | 0 | 0 | 6.83s | |
| ✅ YAML | yamllint | 22 | 0 | 0 | 0.78s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip | Network error: Not Found
📝 Summary
---------------------
🔍 Total..........544
✅ Successful.....540
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........3
❓ Unknown..........0
🚫 Errors...........1
Errors in external/protoc/CMakeLists.txt
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip | Network error: Not Found
⚠️ MARKDOWN / markdownlint - 4 errors
external/crypto/tiny-aes128/README.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "### Tiny AES128 in C"]
external/crypto/tiny-aes128/README.md:29 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:39 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:49 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
⚠️ YAML / prettier - 1 error
[error] Explicitly specified pattern "documents/modules/ROOT/examples/clangformat.yaml" is a symbolic link.
.clusterfuzzlite/project.yaml 41ms (unchanged)
.github/dependabot.yml 40ms (unchanged)
.github/workflows/ci.yml 121ms (unchanged)
.github/workflows/dependency-scanner.yml 24ms (unchanged)
.github/workflows/documentation.yml 20ms (unchanged)
.github/workflows/fuzzing-batch.yml 6ms (unchanged)
.github/workflows/fuzzing-cron.yml 8ms (unchanged)
.github/workflows/fuzzing-pr.yml 7ms (unchanged)
.github/workflows/linting-formatting.yml 24ms (unchanged)
.github/workflows/release-please.yml 26ms (unchanged)
.github/workflows/security.yml 14ms (unchanged)
.github/workflows/social-interaction.yml 8ms (unchanged)
.github/workflows/static-analysis.yml 13ms (unchanged)
.github/workflows/validate-pr.yml 14ms (unchanged)
.ls-lint.yml 3ms
.mega-linter.yml 3ms (unchanged)
antora-playbook-branch.yml 3ms (unchanged)
antora-playbook-site.yml 4ms (unchanged)
documents/antora.yml 8ms (unchanged)
documents/supplemental-ui/ui.yml 1ms (unchanged)
mull.yml 2ms (unchanged)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Member
|
Hi @fabiangottstein 👋🏻 Can you describe what scenario you encountered that triggered this change? I try to keep a test running in the containers to make sure the toolchain file actually works. So I am trying to understand if I missed something there. Next to that, are you sure that invoking the resource compiler (rc) still works when you remove |
Contributor
Author
|
Hi @rjaegers
I tried building for Windows using this toolchain file. Builds from Pipeline on Github runners are successful. Local builds on my machine using the same xwin winsdk fail with an error that
Actually, I will revert this, I was not aware of the resource compiler (nor did I invoke it). |
Set the standard include directories for C/C++ by using the cmake <LANG> identifers `C` and `CXX`.
fabiangottstein
force-pushed
the
fix/windows-include-dirs
branch
from
aeee3f4 to
bfe4ebb
Compare
daantimmer
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Windows toolchain configuration by adding standard include directories for C and C++ compilers. Previously, only the resource compiler (RC) had its standard include directories configured.
Changes:
- Added
CMAKE_C_STANDARD_INCLUDE_DIRECTORIESandCMAKE_CXX_STANDARD_INCLUDE_DIRECTORIESvariables to match the existingCMAKE_RC_STANDARD_INCLUDE_DIRECTORIESconfiguration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the standard include directories for C/C++ by using the cmake
<LANG>identifersCandCXX.