feat: add missing http error codes #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your first PR. We really appreciate it! |
Contributor
Dependency ReviewThe following issues were found:
Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issueslwip/lwip/CMakeLists.txt
external/crypto/mbedtls/CMakeLists.txt
external/crypto/micro-ecc/CMakeLists.txt
external/crypto/tiny-aes128/CMakeLists.txt
external/protobuf/CMakeLists.txt
external/segger_rtt/CMakeLists.txt
infra/syntax/CMakeLists.txt
osal/freertos/CMakeLists.txt
cmake/emil_test_helpers.cmake
external/args/CMakeLists.txt
osal/threadx/CMakeLists.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing HTTP 4xx and 5xx status codes to the HTTP definitions to provide more comprehensive error code coverage.
Changes:
- Added 9 missing 4xx client error status codes (421, 422, 423, 424, 425, 426, 428, 429, 431, 451)
- Added 5 missing 5xx server error status codes (506, 507, 508, 510, 511)
- Updated corresponding parsing and string conversion functions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| services/network/Http.hpp | Added enum values for missing HTTP status codes in the HttpStatusCode enumeration |
| services/network/Http.cpp | Added case statements for parsing and converting the new status codes to strings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0 | 0.29s | |
| ✅ CPP | clang-format | 1053 | 7 | 0 | 0 | 7.63s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.3s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.16s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.49s |
| markdownlint | 6 | 0 | 4 | 0 | 1.2s | |
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0 | 0.26s |
| ✅ REPOSITORY | checkov | yes | no | no | 21.37s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 28.18s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.07s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 7.93s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.47s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.1s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.17s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.29s | |
| lychee | 139 | 2 | 0 | 6.12s | ||
| prettier | 22 | 1 | 1 | 0 | 0.69s | |
| ✅ YAML | v8r | 22 | 0 | 0 | 7.24s | |
| ✅ YAML | yamllint | 22 | 0 | 0 | 0.71s |
Detailed Issues
⚠️ SPELL / lychee - 2 errors
[ERROR] https://securityscorecards.dev/viewer/?uri=github.com/philips-software/amp-embedded-infra-lib | Network error: error sending request for url (https://securityscorecards.dev/viewer/?uri=github.com/philips-software/amp-embedded-infra-lib) Maybe a certificate error?
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip | Network error: Not Found
📝 Summary
---------------------
🔍 Total..........544
✅ Successful.....539
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........3
❓ Unknown..........0
🚫 Errors...........2
Errors in README.md
[ERROR] https://securityscorecards.dev/viewer/?uri=github.com/philips-software/amp-embedded-infra-lib | Network error: error sending request for url (https://securityscorecards.dev/viewer/?uri=github.com/philips-software/amp-embedded-infra-lib) Maybe a certificate error?
Errors in external/protoc/CMakeLists.txt
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip | Network error: Not Found
⚠️ MARKDOWN / markdownlint - 4 errors
external/crypto/tiny-aes128/README.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "### Tiny AES128 in C"]
external/crypto/tiny-aes128/README.md:29 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:39 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:49 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
⚠️ YAML / prettier - 1 error
[error] Explicitly specified pattern "documents/modules/ROOT/examples/clangformat.yaml" is a symbolic link.
.clusterfuzzlite/project.yaml 40ms (unchanged)
.github/dependabot.yml 16ms (unchanged)
.github/workflows/ci.yml 75ms (unchanged)
.github/workflows/dependency-scanner.yml 9ms (unchanged)
.github/workflows/documentation.yml 26ms (unchanged)
.github/workflows/fuzzing-batch.yml 6ms (unchanged)
.github/workflows/fuzzing-cron.yml 5ms (unchanged)
.github/workflows/fuzzing-pr.yml 8ms (unchanged)
.github/workflows/linting-formatting.yml 21ms (unchanged)
.github/workflows/release-please.yml 15ms (unchanged)
.github/workflows/security.yml 10ms (unchanged)
.github/workflows/social-interaction.yml 6ms (unchanged)
.github/workflows/static-analysis.yml 8ms (unchanged)
.github/workflows/validate-pr.yml 10ms (unchanged)
.ls-lint.yml 5ms
.mega-linter.yml 2ms (unchanged)
antora-playbook-branch.yml 3ms (unchanged)
antora-playbook-site.yml 3ms (unchanged)
documents/antora.yml 1ms (unchanged)
documents/supplemental-ui/ui.yml 1ms (unchanged)
mull.yml 2ms (unchanged)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
ccrugoPhilips
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ccrugoPhilips
force-pushed
the
feature/fix-missing-hsdp-error-traces
branch
from
7f119ee to
342874c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
richardapeters
approved these changes
Feb 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing 4xx and 5xx error codes into http definitions.
Modified Http tracing logic to allow any error code in (StatusAvailable is handled) and print "Unknown HTTP status: [code]".