Closed
Conversation
Previously, imports were directly resolved from the IRI, rather than using the version IRI. Update ClosureOntologyParser at multiple points to support this. Add tests for import by IRI and VIRI. Add viri_or_iri method to OntologyID. Clean up resolve.rs
src/io/rdf/closure_reader.rs
Outdated
| let import_closure: Result<Vec<_>, HornedError> = import_iris | ||
| .iter() | ||
| .map(|i| { | ||
| dbg!(i); |
Contributor
There was a problem hiding this comment.
There is a debug statement that should be removed.
localize_iri now returns a PathBuf to stop movement backward and forward between the return and an IRI. resolve_iri has been simplified in code layout. materialize code has been re-worked to be more explicit about dealing with both IRIs and file paths. Other code modified to adapt to these changes.
Previously, resolve_iri tried a single file name for local resolution. We now attempt many options in a defined order. Modify localize_iri to return a Vec with multiple options Add localize_iri_favored to return a single option Adapt other code to new interfaces
This improves the client interface to these functions by removing the necessity for wrapping an IRI in Some.
Owner
Author
|
Updated solution which makes multiple guesses about file names that a IRI could be, and also includes a number of clarifications in code. Comments welcome. annodc parsing now works! |
Owner
Author
|
Rebased onto devel outside of github |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part aiming at addressing:
#153