Merged
Conversation
Internally, this parser uses a lax option and I think I want to maintain strict as the default. So it makes more sense to reverse the semantics.
The old methods conflated several different things -- include methods that worked by side-effect and those that did not. The new naming scheme distinguishes these.
Owner
Author
|
With this version FOAF now parses without error, but does not parse completely. This has involved a fairly radical overhaul of the RDF parser, meaning that it does not check the declared type of an entity where it can infer what it should be, which is invalid in some profiles of OWL2. |
This introduces new methods for distinguish properties pairs, using guesswork if only one of the pair is declared. The mechanisms for detecting OWL/RDF vocabulary is also updated, meaning that (mostly) only the predicates are checked.
Owner
Author
|
This now parses all but four triples in foaf. I am still trying to work out how we know the type of "isPrimaryTypeOf" |
Previously, the RDF parser refused to parse triples where the property type was unknown. It will now use the ObjectProperty as a default.
Owner
Author
|
This now parsers foaf without error in lax mode. It has to use unsupported guesswork to do so as FOAF is not fully specified as an ontology. Some clean ups needed, but comments welcome. Fixing this has resulted in a rather cleaner RDF parser, so I am very glad for the original bug report! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts to address #164