Skip to content

Comments

fix: address code review followup findings#34

Merged
philoserf merged 1 commit intomainfrom
fix/review-followup
Feb 23, 2026
Merged

fix: address code review followup findings#34
philoserf merged 1 commit intomainfrom
fix/review-followup

Conversation

@philoserf
Copy link
Owner

Summary

  • Remove "Claude AI" from manifest.json and package.json descriptions to match vendor-neutral policy
  • Disable title field name setting alongside title prompt when enableTitle is toggled off
  • Remove unreachable null/undefined guard in updateFrontMatter
  • Remove duplicate console.error in generateMetadata catch block
  • Revert JSON regex back to greedy — safer for single-object responses where values may contain braces
  • Fix AGENTS.md test script statement accuracy

Test plan

  • Toggle enableTitle off — both Title Field Name and Title Prompt should be greyed out
  • Generate metadata on a sample note — verify all fields written correctly
  • Trigger an API error (bad key) — confirm single error log in DevTools, not two

🤖 Generated with Claude Code

- Remove "Claude AI" from manifest.json and package.json descriptions
  to match vendor-neutral policy
- Disable title field name setting alongside title prompt when
  enableTitle is toggled off
- Remove unreachable null/undefined guard in updateFrontMatter
- Remove duplicate console.error in generateMetadata catch block
- Revert JSON regex back to greedy — safer for single-object responses
  where values may contain braces
- Fix AGENTS.md test script statement accuracy

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@philoserf philoserf self-assigned this Feb 23, 2026
@philoserf philoserf merged commit c16abc7 into main Feb 23, 2026
@philoserf philoserf deleted the fix/review-followup branch February 23, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant