fix: address code review followup findings#34
Merged
Conversation
- Remove "Claude AI" from manifest.json and package.json descriptions to match vendor-neutral policy - Disable title field name setting alongside title prompt when enableTitle is toggled off - Remove unreachable null/undefined guard in updateFrontMatter - Remove duplicate console.error in generateMetadata catch block - Revert JSON regex back to greedy — safer for single-object responses where values may contain braces - Fix AGENTS.md test script statement accuracy Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest.jsonandpackage.jsondescriptions to match vendor-neutral policyenableTitleis toggled offupdateFrontMatterconsole.erroringenerateMetadatacatch blockTest plan
enableTitleoff — both Title Field Name and Title Prompt should be greyed out🤖 Generated with Claude Code