Resolve some warnings when MSVC warning level is 4#240
Open
Demonese wants to merge 1 commit intophoboslab:masterfrom
Open
Resolve some warnings when MSVC warning level is 4#240Demonese wants to merge 1 commit intophoboslab:masterfrom
Demonese wants to merge 1 commit intophoboslab:masterfrom
Conversation
Demonese
commented
Aug 21, 2022

Author
|
Test build system: cmake_minimum_required(VERSION 3.24)
project(qoi)
add_library(libqoi)
if(MSVC)
target_compile_options(libqoi PRIVATE
"/utf-8"
"/W4"
)
else()
target_compile_options(libqoi PRIVATE
"-Wall"
"-Wextra"
"-Wpedantic"
"-Werror"
)
endif()
if(WIN32)
target_compile_definitions(libqoi PRIVATE
_CRT_SECURE_NO_WARNINGS
)
endif()
set_target_properties(libqoi PROPERTIES
C_STANDARD 17
C_STANDARD_REQUIRED ON
)
target_compile_definitions(libqoi PRIVATE
QOI_IMPLEMENTATION
)
target_include_directories(libqoi PUBLIC
.
)
target_sources(libqoi PRIVATE
qoi.h
qoi.c
)qoi.c #ifndef QOI_IMPLEMENTATION
#define QOI_IMPLEMENTATION
#endif
#include "qoi.h" |
vtorri
reviewed
Aug 14, 2023
|
|
||
| if (run > 0) { | ||
| bytes[p++] = QOI_OP_RUN | (run - 1); | ||
| bytes[p++] = QOI_OP_RUN | (unsigned char)(run - 1); |
Contributor
There was a problem hiding this comment.
why not declaring run as an unsigned char ?
vtorri
reviewed
Aug 14, 2023
|
|
||
| if (index[index_pos].v == px.v) { | ||
| bytes[p++] = QOI_OP_INDEX | index_pos; | ||
| bytes[p++] = QOI_OP_INDEX | (unsigned char)index_pos; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.