Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request refactors input field comments by splitting a single Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can validate your CodeRabbit configuration file in your editor.If your editor has YAML language server, you can enable auto-completion and validation by adding |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
core/src/test/java/org/phoenixctms/ctsms/TestDataProvider.java (1)
280-287: Consider exposingtopCommentin test helper APIs.At Line 280-Line 287 (and similarly in the other
create*Fieldhelpers), fixtures can now set onlybottomComment. Adding optionaltopCommentparameters/overloads would let tests cover both new comment positions.Suggested pattern
-public InputFieldOutVO createIntegerField(String name, String category, String title, String bottomComment, Long longPreset, Long lowerLimit, +public InputFieldOutVO createIntegerField(String name, String category, String title, String topComment, String bottomComment, Long longPreset, Long lowerLimit, Long upperLimit, String validationErrorMessage) throws Exception { InputFieldInVO newInputField = new InputFieldInVO(); ... + newInputField.setTopComment(topComment); newInputField.setBottomComment(bottomComment);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core/src/test/java/org/phoenixctms/ctsms/TestDataProvider.java` around lines 280 - 287, The test helper createIntegerField currently accepts only bottomComment; add an optional topComment parameter (or an overloaded variant) to createIntegerField and mirror the change across other create*Field helpers (e.g., createStringField/createDateField) so fixtures can set both comment positions; update the InputFieldInVO population to call setTopComment(topComment) when provided and preserve existing behavior when null/absent.core/src/main/java/org/phoenixctms/ctsms/pdf/InputFieldPDFBlock.java (1)
112-140: Consider extracting duplicated comment-resolution logic.Top/bottom methods are structurally identical apart from key/label access. A small shared helper would reduce future drift.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core/src/main/java/org/phoenixctms/ctsms/pdf/InputFieldPDFBlock.java` around lines 112 - 140, Extract the duplicated logic from getInputFieldTopComment and getInputFieldBottomComment into a single private helper (e.g., resolveInputFieldComment) that takes the L10n key and a reference to the label-wrapping method; inside the helper, use inputField.getLocalized() and L10nUtil.getInputFieldComment(getLabelLocale(), key) or the raw key, fall back to "" when null, and then call the provided label formatter; update getInputFieldTopComment to call resolveInputFieldComment(inputField.getTopCommentL10nKey(), this::getInputFieldTopCommentLabel) and getInputFieldBottomComment to call resolveInputFieldComment(inputField.getBottomCommentL10nKey(), this::getInputFieldBottomCommentLabel) so getInputFieldTopCommentLabel and getInputFieldBottomCommentLabel remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.java`:
- Around line 31-46: The code currently uses fixed static indices (e.g.,
TOP_COMMENT_COLUMN_INDEX, BOTTOM_COMMENT_COLUMN_INDEX, PRESET_COLUMN_INDEX)
which will corrupt legacy one-comment XLS templates when processed by
InputFieldRowProcessor.processRow(); update the importer so templates are
validated or remapped before row processing: override processHeaderRow() in
InputFieldRowProcessor (or modify init()) to inspect header column names/count
(using getColumnValue()) and either (a) validate the template version/expected
column count and throw a clear exception from XlsImporterBase.readRows() before
processRow() runs, or (b) detect the legacy layout (missing
TOP_COMMENT/BOTTOM_COMMENT headers or fewer columns) and populate a dynamic
column-mapping table used by processRow() instead of the static
TOP_COMMENT_COLUMN_INDEX/PRESET_COLUMN_INDEX constants; also ensure
out-of-bounds getColumnValue() results are treated as a validation error rather
than silently null so mismatches are not masked.
In `@core/src/main/java/org/phoenixctms/ctsms/domain/InputFieldDaoImpl.java`:
- Around line 425-426: The code in InputFieldDaoImpl mistakenly assigns bottom
comment twice (target.setBottomComment(source.getBottomCommentL10nKey()))
leaving topComment unset; replace the second call with
target.setTopComment(source.getTopCommentL10nKey()) so the top comment is
hydrated from source and not lost on edits.
In `@core/src/main/java/org/phoenixctms/ctsms/pdf/InputFieldPDFBlock.java`:
- Around line 112-123: The top/bottom comment getters are passing null/empty
strings into label formatter methods causing static template text to render;
update getInputFieldTopComment (and the corresponding bottom comment method) to
trim and check for blank (e.g., comment == null || comment.trim().isEmpty())
after localization and return an empty string (or skip calling
getInputFieldTopCommentLabel/getInputFieldBottomCommentLabel) when blank,
otherwise call the formatter with the non-empty comment.
---
Nitpick comments:
In `@core/src/main/java/org/phoenixctms/ctsms/pdf/InputFieldPDFBlock.java`:
- Around line 112-140: Extract the duplicated logic from getInputFieldTopComment
and getInputFieldBottomComment into a single private helper (e.g.,
resolveInputFieldComment) that takes the L10n key and a reference to the
label-wrapping method; inside the helper, use inputField.getLocalized() and
L10nUtil.getInputFieldComment(getLabelLocale(), key) or the raw key, fall back
to "" when null, and then call the provided label formatter; update
getInputFieldTopComment to call
resolveInputFieldComment(inputField.getTopCommentL10nKey(),
this::getInputFieldTopCommentLabel) and getInputFieldBottomComment to call
resolveInputFieldComment(inputField.getBottomCommentL10nKey(),
this::getInputFieldBottomCommentLabel) so getInputFieldTopCommentLabel and
getInputFieldBottomCommentLabel remain unchanged.
In `@core/src/test/java/org/phoenixctms/ctsms/TestDataProvider.java`:
- Around line 280-287: The test helper createIntegerField currently accepts only
bottomComment; add an optional topComment parameter (or an overloaded variant)
to createIntegerField and mirror the change across other create*Field helpers
(e.g., createStringField/createDateField) so fixtures can set both comment
positions; update the InputFieldInVO population to call
setTopComment(topComment) when provided and preserve existing behavior when
null/absent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6edc0a2b-44d0-47f4-9a50-e4edb464efd6
⛔ Files ignored due to path filters (2)
core/src/test/resources/ecrfs.xlsis excluded by!**/*.xlscore/src/test/resources/input_fields.xlsis excluded by!**/*.xls
📒 Files selected for processing (51)
core/db/schema-create.sqlcore/db/schema-set-version.sqlcore/db/schema-up-master.sqlcore/src/exec/java/org/phoenixctms/ctsms/executable/DemoDataProvider.javacore/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.javacore/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowWriter.javacore/src/main/java/org/phoenixctms/ctsms/domain/InputFieldDaoImpl.javacore/src/main/java/org/phoenixctms/ctsms/pdf/EcrfPDFBlock.javacore/src/main/java/org/phoenixctms/ctsms/pdf/EcrfPDFLabelCodes.javacore/src/main/java/org/phoenixctms/ctsms/pdf/InputFieldPDFBlock.javacore/src/main/java/org/phoenixctms/ctsms/pdf/InquiriesPDFBlock.javacore/src/main/java/org/phoenixctms/ctsms/pdf/InquiriesPDFLabelCodes.javacore/src/main/java/org/phoenixctms/ctsms/pdf/ProbandListEntryTagsPDFBlock.javacore/src/main/java/org/phoenixctms/ctsms/pdf/ProbandListEntryTagsPDFLabelCodes.javacore/src/main/java/org/phoenixctms/ctsms/service/shared/InputFieldServiceImpl.javacore/src/main/java/org/phoenixctms/ctsms/util/ServiceUtil.javacore/src/main/java/org/phoenixctms/ctsms/vocycle/InputFieldGraph.javacore/src/main/resources/ctsms-ecrf-pdf-labels.propertiescore/src/main/resources/ctsms-ecrf-pdf-labels_de.propertiescore/src/main/resources/ctsms-inquiries-pdf-labels.propertiescore/src/main/resources/ctsms-inquiries-pdf-labels_de.propertiescore/src/main/resources/ctsms-probandlistentrytags-pdf-labels.propertiescore/src/main/resources/ctsms-probandlistentrytags-pdf-labels_de.propertiescore/src/test/java/org/phoenixctms/ctsms/TestDataProvider.javamda/src/main/uml/UML_Standard_Profile.MagicDraw_Profile.DSL_Customization.profile.umlmda/src/main/uml/UML_Standard_Profile.MagicDraw_Profile.Traceability_customization.profile.umlmda/src/main/uml/UML_Standard_Profile.MagicDraw_Profile.profile.umlmda/src/main/uml/UML_Standard_Profile.StandardProfileL2.profile.umlmda/src/main/uml/UML_Standard_Profile.StandardProfileL3.profile.umlmda/src/main/uml/UML_Standard_Profile.Validation_Profile.profile.umlmda/src/main/uml/andromda-common.andromda-persistence.profile.umlmda/src/main/uml/andromda-common.andromda-service.profile.umlmda/src/main/uml/andromda-common.profile.umlmda/src/main/uml/andromda-presentation.profile.umlmda/src/main/uml/andromda-process.profile.umlmda/src/main/uml/andromda-webservice.profile.umlmda/src/main/uml/andromda-xml.profile.umlmda/src/main/uml/ctsms.umlmda/src/main/uml/ctsms.xmlweb/src/main/java/org/phoenixctms/ctsms/web/model/inputfield/InputFieldBean.javaweb/src/main/java/org/phoenixctms/ctsms/web/model/shared/inputfield/InputFieldConfig.javaweb/src/main/java/org/phoenixctms/ctsms/web/model/shared/inputfield/InputFieldInVOConfig.javaweb/src/main/java/org/phoenixctms/ctsms/web/model/shared/inputfield/InputFieldOutVOConfigBase.javaweb/src/main/java/org/phoenixctms/ctsms/web/model/shared/inputfield/InputModel.javaweb/src/main/java/org/phoenixctms/ctsms/web/util/MessageCodes.javaweb/src/main/resources/org/phoenixctms/ctsms/web/inputfield/labels.propertiesweb/src/main/resources/org/phoenixctms/ctsms/web/inputfield/labels_de.propertiesweb/src/main/resources/org/phoenixctms/ctsms/web/messages.propertiesweb/src/main/resources/org/phoenixctms/ctsms/web/messages_de.propertiesweb/src/main/webapp/META-INF/includes/inputfield/inputFieldMain.xhtmlweb/src/main/webapp/META-INF/includes/shared/inputFieldRow.xhtml
Comment on lines
+31
to
+46
| private final static int TOP_COMMENT_COLUMN_INDEX = 6; | ||
| private final static int BOTTOM_COMMENT_COLUMN_INDEX = 7; | ||
| private final static int PRESET_COLUMN_INDEX = 8; | ||
| private final static int TEXT_PRESET_COLUMN_INDEX = PRESET_COLUMN_INDEX; | ||
| private final static int BOOLEAN_PRESET_COLUMN_INDEX = PRESET_COLUMN_INDEX; | ||
| private final static int LONG_PRESET_COLUMN_INDEX = PRESET_COLUMN_INDEX; | ||
| private final static int FLOAT_PRESET_COLUMN_INDEX = PRESET_COLUMN_INDEX; | ||
| private final static int DATE_PRESET_COLUMN_INDEX = PRESET_COLUMN_INDEX; | ||
| private final static int TIME_PRESET_COLUMN_INDEX = PRESET_COLUMN_INDEX; | ||
| private final static int TIMESTAMP_PRESET_COLUMN_INDEX = PRESET_COLUMN_INDEX; | ||
| private final static int VALIDATION_ERROR_MSG_COLUMN_INDEX = 8; | ||
| private final static int PARAM_1_COLUMN_INDEX = 9; | ||
| private final static int PARAM_2_COLUMN_INDEX = 10; | ||
| private final static int PARAM_3_COLUMN_INDEX = 11; | ||
| private final static int PARAM_4_COLUMN_INDEX = 12; | ||
| private final static int PARAM_5_COLUMN_INDEX = 13; | ||
| private final static int VALIDATION_ERROR_MSG_COLUMN_INDEX = 9; | ||
| private final static int PARAM_1_COLUMN_INDEX = 10; | ||
| private final static int PARAM_2_COLUMN_INDEX = 11; | ||
| private final static int PARAM_3_COLUMN_INDEX = 12; | ||
| private final static int PARAM_4_COLUMN_INDEX = 13; | ||
| private final static int PARAM_5_COLUMN_INDEX = 14; |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILES="$(fd 'InputFieldRowProcessor.java|InputFieldRowWriter.java|XlsImporter.java|RowProcessor.java')"
echo "Relevant XLS import/export files:"
printf '%s\n' "$FILES"
echo
echo "Current fixed column layout in InputFieldRowProcessor:"
sed -n '24,70p' core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.java
echo
echo "Search for header/template validation or legacy remapping:"
rg -n -C3 'template.?version|sheet.?version|header|column.?name|legacy|getColumnValue\(|TOP_COMMENT_COLUMN_INDEX|BOTTOM_COMMENT_COLUMN_INDEX' $FILESRepository: phoenixctms/ctsms
Length of output: 50373
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Checking XlsImporter for version/template validation ==="
rg -n -A10 "processRow|init|version|template|header" core/src/exec/java/org/phoenixctms/ctsms/executable/xls/XlsImporter.java | head -100
echo ""
echo "=== Checking RowProcessor base class for init logic ==="
rg -n -A15 "void init|columnIndex.*=" common/src/main/java/org/phoenixctms/ctsms/fileprocessors/xls/RowProcessor.java | head -80
echo ""
echo "=== Looking for any legacy/version handling in InputFieldRowProcessor init ==="
rg -n -B3 -A20 "void init\|initHeaderCellIndex" core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.java | head -120
echo ""
echo "=== Checking if column count is validated before row processing ==="
rg -n "values\.length|columnIndex|throw.*Exception" core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.java | grep -E "(length|throw|Exception|MIN|MAX)" | head -20Repository: phoenixctms/ctsms
Length of output: 121
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== XlsImporter.java size and processRow logic ==="
wc -l core/src/exec/java/org/phoenixctms/ctsms/executable/xls/XlsImporter.java
echo ""
# Look for how row processors are invoked
rg -n "new InputFieldRowProcessor|processRow|init(" core/src/exec/java/org/phoenixctms/ctsms/executable/xls/XlsImporter.java | head -30
echo ""
echo "=== RowProcessor base class ==="
wc -l common/src/main/java/org/phoenixctms/ctsms/fileprocessors/xls/RowProcessor.java
echo ""
# Read the init method area
sed -n '1,120p' common/src/main/java/org/phoenixctms/ctsms/fileprocessors/xls/RowProcessor.java
echo ""
echo "=== InputFieldRowProcessor.init() method ==="
sed -n '263,330p' core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.javaRepository: phoenixctms/ctsms
Length of output: 343
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Full XlsImporter.java ==="
cat core/src/exec/java/org/phoenixctms/ctsms/executable/xls/XlsImporter.java
echo ""
echo "=== RowProcessor.java (first 150 lines for init pattern) ==="
head -150 common/src/main/java/org/phoenixctms/ctsms/fileprocessors/xls/RowProcessor.java
echo ""
echo "=== InputFieldRowProcessor.init() and surrounding context ==="
sed -n '263,340p' core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.javaRepository: phoenixctms/ctsms
Length of output: 15163
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Check if InputFieldRowProcessor overrides processHeaderRow ==="
grep -n "processHeaderRow" core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.java
echo ""
echo "=== Check for any version/metadata handling in InputFieldRowProcessor ==="
grep -n "version\|metadata\|header\|template" core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.java
echo ""
echo "=== Check XlsImporterBase for any pre-import validation ==="
wc -l core/src/exec/java/org/phoenixctms/ctsms/executable/xls/XlsImporterBase.java 2>/dev/null || echo "File may be in common module"
grep -n "version\|header\|template\|validate" core/src/exec/java/org/phoenixctms/ctsms/executable/xls/XlsImporterBase.java 2>/dev/null | head -20 || \
grep -rn "version\|header.*template" common/src/main/java/org/phoenixctms/ctsms/fileprocessors/xls/XlsImporterBase.java 2>/dev/null | head -20
echo ""
echo "=== Check if there's a common XlsImporterBase with validation ==="
fd "XlsImporterBase.java" --exec cat {} \;Repository: phoenixctms/ctsms
Length of output: 127
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Locate XlsImporterBase ==="
fd "XlsImporterBase.java"
echo ""
echo "=== Read XlsImporterBase ==="
fd "XlsImporterBase.java" -x cat {}Repository: phoenixctms/ctsms
Length of output: 3164
Legacy one-comment XLS templates will be silently corrupted during import.
Two new fixed columns (TOP_COMMENT at index 6, BOTTOM_COMMENT at index 7) shift every subsequent column. If an older template without these columns reaches InputFieldRowProcessor.processRow(), the old preset value (index 6) becomes topComment, the old validation message (index 7) becomes bottomComment, and all validation parameters shift right.
The init() method uses only static column indices with no dynamic mapping. processHeaderRow() is not overridden, and XlsImporterBase.readRows() performs no version or column-count validation before row processing. getColumnValue() silently returns null for out-of-bounds indices, masking the mismatch.
Verify that either:
- The XLS import template version is validated before
processRow()executes, or - Legacy column layouts are explicitly detected and remapped
Otherwise older templates will import with corrupted field metadata.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@core/src/exec/java/org/phoenixctms/ctsms/executable/xls/InputFieldRowProcessor.java`
around lines 31 - 46, The code currently uses fixed static indices (e.g.,
TOP_COMMENT_COLUMN_INDEX, BOTTOM_COMMENT_COLUMN_INDEX, PRESET_COLUMN_INDEX)
which will corrupt legacy one-comment XLS templates when processed by
InputFieldRowProcessor.processRow(); update the importer so templates are
validated or remapped before row processing: override processHeaderRow() in
InputFieldRowProcessor (or modify init()) to inspect header column names/count
(using getColumnValue()) and either (a) validate the template version/expected
column count and throw a clear exception from XlsImporterBase.readRows() before
processRow() runs, or (b) detect the legacy layout (missing
TOP_COMMENT/BOTTOM_COMMENT headers or fewer columns) and populate a dynamic
column-mapping table used by processRow() instead of the static
TOP_COMMENT_COLUMN_INDEX/PRESET_COLUMN_INDEX constants; also ensure
out-of-bounds getColumnValue() results are treated as a validation error rather
than silently null so mismatches are not masked.
core/src/main/java/org/phoenixctms/ctsms/domain/InputFieldDaoImpl.java
Outdated
Show resolved
Hide resolved
Comment on lines
+112
to
123
| private String getInputFieldTopComment() { | ||
| String comment; | ||
| if (inputField.getLocalized()) { | ||
| comment = L10nUtil.getInputFieldComment(getLabelLocale(), inputField.getCommentL10nKey()); | ||
| comment = L10nUtil.getInputFieldComment(getLabelLocale(), inputField.getTopCommentL10nKey()); | ||
| } else { | ||
| comment = inputField.getCommentL10nKey(); | ||
| comment = inputField.getTopCommentL10nKey(); | ||
| } | ||
| if (comment == null) { | ||
| comment = ""; | ||
| } | ||
| return getInputFieldCommentLabel(comment); | ||
| return getInputFieldTopCommentLabel(comment); | ||
| } |
Contributor
There was a problem hiding this comment.
Avoid formatting empty comments into visible label text.
At Line 122 and Line 137, empty/null comments are still passed into label formatters. If those templates contain static text, top/bottom comment rows render even when no comment exists.
Suggested fix
private String getInputFieldTopComment() {
String comment;
if (inputField.getLocalized()) {
comment = L10nUtil.getInputFieldComment(getLabelLocale(), inputField.getTopCommentL10nKey());
} else {
comment = inputField.getTopCommentL10nKey();
}
- if (comment == null) {
- comment = "";
- }
+ if (CommonUtil.isEmptyString(comment)) {
+ return "";
+ }
return getInputFieldTopCommentLabel(comment);
}
...
private String getInputFieldBottomComment() {
String comment;
if (inputField.getLocalized()) {
comment = L10nUtil.getInputFieldComment(getLabelLocale(), inputField.getBottomCommentL10nKey());
} else {
comment = inputField.getBottomCommentL10nKey();
}
- if (comment == null) {
- comment = "";
- }
+ if (CommonUtil.isEmptyString(comment)) {
+ return "";
+ }
return getInputFieldBottomCommentLabel(comment);
}Also applies to: 127-138
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@core/src/main/java/org/phoenixctms/ctsms/pdf/InputFieldPDFBlock.java` around
lines 112 - 123, The top/bottom comment getters are passing null/empty strings
into label formatter methods causing static template text to render; update
getInputFieldTopComment (and the corresponding bottom comment method) to trim
and check for blank (e.g., comment == null || comment.trim().isEmpty()) after
localization and return an empty string (or skip calling
getInputFieldTopCommentLabel/getInputFieldBottomCommentLabel) when blank,
otherwise call the formatter with the non-empty comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores