Skip to content

Prevent invalid markup in generators #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteffenDE merged 2 commits into from
Nov 26, 2024
Merged

Prevent invalid markup in generators #5820

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20a2638
prevent invalid markup in generators
SteffenDE Nov 26, 2024
c72b7be
update LV in integration tests
SteffenDE Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions priv/templates/phx.gen.html/index.html.heex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<.header>
Listing <%= schema.human_plural %>
<:actions>
<.link href={~p"<%= schema.route_prefix %>/new"}>
<.button>New <%= schema.human_singular %></.button>
</.link>
<.button phx-click={JS.dispatch("click", to: {:inner, "a"})}>
<.link href={~p"<%= schema.route_prefix %>/new"}>
New <%= schema.human_singular %>
</.link>
</.button>
</:actions>
</.header>

Expand Down
8 changes: 5 additions & 3 deletions priv/templates/phx.gen.html/show.html.heex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
<%= schema.human_singular %> <%%= @<%= schema.singular %>.id %>
<:subtitle>This is a <%= schema.singular %> record from your database.</:subtitle>
<:actions>
<.link href={~p"<%= schema.route_prefix %>/#{@<%= schema.singular %>}/edit"}>
<.button>Edit <%= schema.singular %></.button>
</.link>
<.button phx-click={JS.dispatch("click", to: {:inner, "a"})}>
<.link href={~p"<%= schema.route_prefix %>/#{@<%= schema.singular %>}/edit"}>
Edit <%= schema.singular %>
</.link>
</.button>
</:actions>
</.header>

Expand Down
8 changes: 5 additions & 3 deletions priv/templates/phx.gen.live/index.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ defmodule <%= inspect context.web_module %>.<%= inspect Module.concat(schema.web
<.header>
Listing <%= schema.human_plural %>
<:actions>
<.link navigate={~p"<%= schema.route_prefix %>/new"}>
<.button>New <%= schema.human_singular %></.button>
</.link>
<.button phx-click={JS.dispatch("click", to: {:inner, "a"})}>
<.link navigate={~p"<%= schema.route_prefix %>/new"}>
New <%= schema.human_singular %>
</.link>
</.button>
</:actions>
</.header>

Expand Down
8 changes: 5 additions & 3 deletions priv/templates/phx.gen.live/show.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ defmodule <%= inspect context.web_module %>.<%= inspect Module.concat(schema.web
<%= schema.human_singular %> <%%= @<%= schema.singular %>.id %>
<:subtitle>This is a <%= schema.singular %> record from your database.</:subtitle>
<:actions>
<.link navigate={~p"<%= schema.route_prefix %>/#{@<%= schema.singular %>}/edit?return_to=show"}>
<.button>Edit <%= schema.singular %></.button>
</.link>
<.button phx-click={JS.dispatch("click", to: {:inner, "a"})}>
<.link navigate={~p"<%= schema.route_prefix %>/#{@<%= schema.singular %>}/edit?return_to=show"}>
Edit <%= schema.singular %>
</.link>
</.button>
</:actions>
</.header>

Expand Down