Preserve original name when as is not provided to simple_form
#5975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the default `nil` value for the `as` attribute in the generated
`simple_form` core component.
This default interferes with the form name present in the form struct
provided through the component's `for` attribute when used with `:let=`.
For example, consider the following code:
```
<.simple_form :let={f} for={@Form}>
<%= inspect(f.name) %>
<.input field={f[:bar]} label="Bar" />
</.simple_form>
```
When rendered, `f.name` is `nil`, and the `name` attribute of the form
field only contains `bar`, missing the proper field name prefix from
the form struct:
```
<div class="mt-10 space-y-8 bg-white">
nil
<div data-phx-id="m9-phx-GAgAfRg6YU4XV6tC">
<label for="bar" class="block text-sm font-semibold leading-6 text-zinc-800" data-phx-id="m10-phx-GAgAfRg6YU4XV6tC">
Bar
</label>
<input type="text" name="bar" id="bar" class="mt-2 block w-full rounded-lg text-zinc-900 focus:ring-0 sm:text-sm sm:leading-6 border-zinc-300 focus:border-zinc-400">
</div>
</div>
```
This issue been reported [over here](phoenixframework#5901).
Fixes phoenixframework#5901
rmoorman
force-pushed
the
simple-form-default-for-as-overrides-name-from-form-struct
branch
from
11a3c4f to
19680de
Compare
Contributor
|
Thank you! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the default
nilvalue for theasattribute in the generatedsimple_formcore component.This default interferes with the form name present in the form struct provided through the component's
forattribute when used with:let=.For example, consider the following code:
When rendered,
f.nameisnil, and thenameattribute of the form field only containsbar, missing the proper field name prefix from the form struct:This issue been reported over here.
Fixes #5901