Skip to content

raise when using form as schema name in phx.gen.live #6079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteffenDE merged 1 commit into from
Feb 14, 2025
Merged

raise when using form as schema name in phx.gen.live #6079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/mix/tasks/phx.gen.live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ defmodule Mix.Tasks.Phx.Gen.Live do
Mix.Phoenix.ensure_live_view_compat!(__MODULE__)

{context, schema} = Gen.Context.build(args)
validate_context!(context)

Gen.Context.prompt_for_code_injection(context)

binding = [context: context, schema: schema, inputs: inputs(schema)]
Expand All @@ -129,6 +131,16 @@ defmodule Mix.Tasks.Phx.Gen.Live do
|> print_shell_instructions()
end

defp validate_context!(context) do
cond do
context.schema.singular == "form" ->
Gen.Context.raise_with_help("cannot use form as the schema name because it conflicts with the LiveView assigns!")

true ->
:ok
end
end

defp prompt_for_conflicts(context) do
context
|> files_to_be_generated()
Expand Down
6 changes: 6 additions & 0 deletions test/mix/tasks/phx.gen.live_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,4 +433,10 @@ defmodule Mix.Tasks.Phx.Gen.LiveTest do
end
end
end

test "raises on schema named form" do
assert_raise Mix.Error, ~r/cannot use form as the schema name because it conflicts with the LiveView assigns/, fn ->
Mix.Tasks.Phx.Gen.Live.run(~w(Blog Form forms title:string))
end
end
end
Loading