Skip to content

revert code reloader changed file detection #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteffenDE merged 2 commits into from
Feb 14, 2025
Merged

revert code reloader changed file detection #6085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17491cc
revert code reloader changed file detection
SteffenDE Feb 14, 2025
5fb0e6a
Update lib/phoenix/code_reloader/server.ex
SteffenDE Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions lib/phoenix/code_reloader/server.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,17 +289,8 @@ defmodule Phoenix.CodeReloader.Server do

defp mix_compile_unless_stale_config(compilers, compile_args, timestamp, path, purge_fallback?) do
manifests = Mix.Tasks.Compile.Elixir.manifests()
configs = Mix.Project.config_files()
config = Mix.Project.config()
build_path = Mix.Project.build_path(config)

# Stop if lock or config files change.
# We don't check for mix.exs because changes there that require recompilation
# are often related to deps or configs anyway.
# We also explicitly remove checks for entries in _build because reporting
# them is confusing and they are mostly used for internal Mix book-keeping.
configs =
[config[:lockfile] | Mix.Project.config_files()]
|> Enum.reject(&String.starts_with?(&1, build_path))

case Mix.Utils.extract_stale(configs, manifests) do
[] ->
Expand All @@ -316,7 +307,8 @@ defmodule Phoenix.CodeReloader.Server do
raise """
could not compile application: #{Mix.Project.config()[:app]}.

You must restart your server after changing the following files:
You must restart your server after changing configuration files or your dependencies.
In particular, the following files changed and must be recomputed on a server restart:

* #{Enum.map_join(files, "\n * ", &Path.relative_to_cwd/1)}

Expand Down
Loading