Fix LongPoll transport name in sessionStorage and logs#6562
Merged
chrismccord merged 1 commit intophoenixframework:mainfrom Feb 2, 2026
Merged
Conversation
Projects created with `mix phx.new` enable JavaScript minification by default in production. This renames symbols to reduce code size, including the LongPoll transport class name. As a result, when the Socket falls back to LongPoll, it stores something like `phx:fallback:Jt` in sessionStorage instead of the expected `phx:fallback:LongPoll` (as it does in development). The shortened name is not guaranteed to be stable across builds, leading to unintended behavior when deploying new versions of an app. The transport name was also used in log messages, which now will also preserve the correct LongPoll name.
Contributor
Author
|
Open to suggestions on what would be useful automated tests for this. I looked at Note |
SteffenDE
approved these changes
Dec 16, 2025
Member
|
❤️❤️❤️🐥🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects created with
mix phx.newenable JavaScript minification by default in production. This renames symbols to reduce code size, including the LongPoll transport class name.As a result, when the Socket falls back to LongPoll, it stores something like
phx:fallback:Jtin sessionStorage instead of the expectedphx:fallback:LongPoll(as it does in development).The shortened name is not guaranteed to be stable across builds, leading to unintended behavior when deploying new versions of an app.
The transport name was also used in log messages, which now will also preserve the correct LongPoll name.