Skip to content

Annotate around slots and add data-phx-loc#3811

Closed
josevalim wants to merge 24 commits intomainfrom
jv-slot-annotations-macro-component
Closed

Annotate around slots and add data-phx-loc#3811
josevalim wants to merge 24 commits intomainfrom
jv-slot-annotations-macro-component

Conversation

@josevalim
Copy link
Member

Currently it targets the sd-macro-component branch but it should change to main once sd-macro-component is merged.

@josevalim josevalim force-pushed the jv-slot-annotations-macro-component branch from e237157 to 7a67911 Compare May 25, 2025 09:23
@SteffenDE SteffenDE changed the title Annotate around slots and add data-phx-line Annotate around slots and add data-phx-loc May 25, 2025
Copy link
Collaborator

@SteffenDE SteffenDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SteffenDE SteffenDE force-pushed the sd-macro-component branch 2 times, most recently from 17c6308 to 4f29fc3 Compare May 26, 2025 13:26
@SteffenDE SteffenDE added this to the v1.1 milestone May 27, 2025
@SteffenDE SteffenDE force-pushed the sd-macro-component branch 2 times, most recently from aefaaa0 to 2d1c6e6 Compare May 27, 2025 15:29
Base automatically changed from sd-macro-component to main May 30, 2025 09:49
@josevalim
Copy link
Member Author

Merged manually!

@josevalim josevalim closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants