Merged
Conversation
This is required for backwards compatibility. When re-writing the code to support giving classes, I added a check to prevent overwriting the hook's own properties, but this is actually used by hooks in the wild, so we only log a warning instead.
SteffenDE
force-pushed
the
sd-allow-prop-overwrite
branch
from
34e71a4 to
1f107e7
Compare
SteffenDE
added a commit
that referenced
this pull request
Jun 30, 2025
This is required for backwards compatibility. When re-writing the code to support giving classes, I added a check to prevent overwriting the hook's own properties, but this is actually used by hooks in the wild, so we only log a warning instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for backwards compatibility. When re-writing the code to support giving classes, I added a check to prevent overwriting the hook's own properties, but this is actually used by hooks in the wild, so we only log a warning instead.