Adds A Generic El Type Parameter To Hooks Interfaces - #3961
Merged
SteffenDE merged 1 commit intoAug 28, 2025
Merged
Conversation
IdoLeshkowitz
marked this pull request as ready for review
August 24, 2025 09:10
IdoLeshkowitz
marked this pull request as draft
August 27, 2025 22:06
IdoLeshkowitz
force-pushed
the
allow-passing-el-type-to-hooks
branch
from
August 27, 2025 22:06
be51470 to
4664e8f
Compare
IdoLeshkowitz
marked this pull request as ready for review
August 27, 2025 22:06
Member
|
Thank you :) |
SteffenDE
pushed a commit
that referenced
this pull request
Sep 2, 2025
Contributor
|
What's the expected usage of this? I would have expected |
Member
|
@vanderhoop Hook already had a first generic argument in case you wanted to type other methods or attributes yourself. So it should be interface SpecificHook {
customAttribute: string;
}
const specificHook: Hook<SpecificHook, HTMLInputElement> = {...}; |
Contributor
|
thanks @SteffenDE! onward! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3956