Skip to content

Conversation

@SteffenDE
Copy link
Collaborator

Closes #4070.

@SteffenDE SteffenDE merged commit 891696a into main Dec 12, 2025
16 checks passed
@SteffenDE SteffenDE deleted the sd-clickaway-visibility branch December 12, 2025 15:46
SteffenDE added a commit that referenced this pull request Dec 12, 2025
@maltoe
Copy link

maltoe commented Dec 12, 2025

Thank you!

Are you sure this has no further implications elsewhere? E.g., wouldn't it affect people who dispatch a JS.click with an explicit target on an element outside their click-away that is hidden for whatever reason?

@SteffenDE
Copy link
Collaborator Author

It would, but I think it's fairly unlikely that people rely on it and even if they do, changing such code to click on something like document.body should work. Either that or we can't really fix your problem. We could adjust phoenix_html to set a special attribute we can detect, but I think this is fine for now. We can reevaluate if people run into problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

phx-click-away triggers if external POST link is clicked

3 participants