Allow 'rediss' URL scheme to define whether SSL is enabled#58
Closed
tomtaylor wants to merge 1 commit intophoenixframework:masterfrom
Closed
Allow 'rediss' URL scheme to define whether SSL is enabled#58tomtaylor wants to merge 1 commit intophoenixframework:masterfrom
tomtaylor wants to merge 1 commit intophoenixframework:masterfrom
Conversation
tomtaylor
changed the title
If the URL uses the 'rediss' scheme, SSL should be enabled. This follows the behaviour of Redix standalone and embedded in other libraries.
tomtaylor
force-pushed
the
reddis-scheme-support
branch
from
504caa5 to
f98b5f6
Compare
Contributor
Author
|
@chrismccord any thoughts on this? |
|
we are also experiencing this issue. |
Collaborator
|
This should be addressed with #76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the
REDIS_URLenv var on Heroku to define our Redis URL. When SSL is enabled this is indicated by theredissscheme in the URL.As it stands,
phoenix_pubsub_redisignores this, and forces us to setssl: trueto use SSL for the connection.This change allows the URL scheme to define whether SSL is enabled, removing the need to keep the
:sslsetting inline with the URL scheme.